Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azurerm_storage_blob_inventory_policy - support for deleted blobs in inventory policy via include_deleted property on filters #19286

Merged

Conversation

dknott-arcadis
Copy link
Contributor

Adds support for the "includeDeleted" flag on blob and container inventory policies. See Microsoft documentation for more information.

PR includes:

  • Implementation of includeDeleted flag
  • Modification of acceptance tests to include testing includeDeleted flag
  • Modification of documentation to include new include_deleted property on filters

Closes #19279

Acceptance tests pass:

TF_ACC=1 go test -v ./internal/services/storage -run=TestAccStorageBlobInventoryPolicy_.* -timeout 60m -ldflags="-X=github.com/hashicorp/terraform-provider-azurerm/version.ProviderVersion=acc"
=== RUN   TestAccStorageBlobInventoryPolicy_basic
=== PAUSE TestAccStorageBlobInventoryPolicy_basic
=== RUN   TestAccStorageBlobInventoryPolicy_requiresImport
=== PAUSE TestAccStorageBlobInventoryPolicy_requiresImport
=== RUN   TestAccStorageBlobInventoryPolicy_complete
=== PAUSE TestAccStorageBlobInventoryPolicy_complete
=== RUN   TestAccStorageBlobInventoryPolicy_update
=== PAUSE TestAccStorageBlobInventoryPolicy_update
=== CONT  TestAccStorageBlobInventoryPolicy_basic
=== CONT  TestAccStorageBlobInventoryPolicy_complete
=== CONT  TestAccStorageBlobInventoryPolicy_update
=== CONT  TestAccStorageBlobInventoryPolicy_requiresImport
--- PASS: TestAccStorageBlobInventoryPolicy_complete (162.97s)
--- PASS: TestAccStorageBlobInventoryPolicy_requiresImport (189.53s)
--- PASS: TestAccStorageBlobInventoryPolicy_basic (222.85s)
--- PASS: TestAccStorageBlobInventoryPolicy_update (390.16s)
PASS
ok      github.com/hashicorp/terraform-provider-azurerm/internal/services/storage       390.172s

@dknott-arcadis dknott-arcadis changed the title support for deleted blobs in inventory policy via include_deleted property on filters azurerm_storage_blob_inventory_policy - support for deleted blobs in inventory policy via include_deleted property on filters Nov 15, 2022
@dknott-arcadis dknott-arcadis changed the title azurerm_storage_blob_inventory_policy - support for deleted blobs in inventory policy via include_deleted property on filters azurerm_storage_blob_inventory_policy - support for deleted blobs in inventory policy via include_deleted property on filters Nov 15, 2022
Copy link
Member

@catriona-m catriona-m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @dknott-arcadis LGTM!

@catriona-m catriona-m merged commit cb8c30b into hashicorp:main Nov 17, 2022
@github-actions github-actions bot added this to the v3.32.0 milestone Nov 17, 2022
catriona-m added a commit that referenced this pull request Nov 17, 2022
@dknott-arcadis dknott-arcadis deleted the blob-inventory-policy-support-deleted branch November 17, 2022 12:20
@github-actions
Copy link

This functionality has been released in v3.32.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

azurerm_storage_blob_inventory_policy support for deleted blobs
2 participants