Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

azurerm_integration_service_environment - mark as deprecated #19265

Merged
merged 2 commits into from
Nov 14, 2022
Merged

azurerm_integration_service_environment - mark as deprecated #19265

merged 2 commits into from
Nov 14, 2022

Conversation

ziyeqf
Copy link
Contributor

@ziyeqf ziyeqf commented Nov 14, 2022

azurerm_integration_service_environment is getting deprecated (https://techcommunity.microsoft.com/t5/integrations-on-azure-blog/ise-retirement-what-you-need-to-know/ba-p/3645220). Mark it as deprecated in provider.

tombuildsstuff
tombuildsstuff suggested changes Nov 14, 2022
View reviewed changes
Copy link
Contributor

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hey @ziyeqf

Thanks for this PR - I've taken a look through and left a couple of comments inline, if we can fix those up to clarify this then we should be able to get this merged 👍

Thanks!

internal/services/logic/integration_service_environment.go Outdated Show resolved Hide resolved
website/docs/r/integration_service_environment.html.markdown Outdated Show resolved Hide resolved
@tombuildsstuff tombuildsstuff added this to the v3.32.0 milestone Nov 14, 2022
@tombuildsstuff tombuildsstuff merged commit a93e6cb into hashicorp:main Nov 14, 2022
tombuildsstuff added a commit that referenced this pull request Nov 14, 2022
@tombuildsstuff
updating to include #19265
eb025d0
@ziyeqf ziyeqf deleted the tengzh/ise_deprecated branch November 14, 2022 10:01
@github-actions
Copy link

This functionality has been released in v3.32.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@tombuildsstuff tombuildsstuff tombuildsstuff approved these changes

Assignees
No one assigned
Labels
documentation service/logic size/XS
Projects
None yet
Milestone
v3.32.0
Development

Successfully merging this pull request may close these issues.
2 participants
@ziyeqf @tombuildsstuff