Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azurerm_sentinel_alert_rule_nrt - Add support for techniques #19142

Merged
merged 1 commit into from
Nov 8, 2022

Conversation

magodo
Copy link
Collaborator

@magodo magodo commented Nov 4, 2022

azurerm_sentinel_alert_rule_nrt add new property techniques.

Test

💤  TF_ACC=1 go test -v -timeout=20h ./internal/services/sentinel -run=TestAccSentinelAlertRuleNrt_
=== RUN   TestAccSentinelAlertRuleNrt_basic
=== PAUSE TestAccSentinelAlertRuleNrt_basic
=== RUN   TestAccSentinelAlertRuleNrt_complete
=== PAUSE TestAccSentinelAlertRuleNrt_complete
=== RUN   TestAccSentinelAlertRuleNrt_update
=== PAUSE TestAccSentinelAlertRuleNrt_update
=== RUN   TestAccSentinelAlertRuleNrt_requiresImport
=== PAUSE TestAccSentinelAlertRuleNrt_requiresImport
=== RUN   TestAccSentinelAlertRuleNrt_withAlertRuleTemplateGuid
=== PAUSE TestAccSentinelAlertRuleNrt_withAlertRuleTemplateGuid
=== CONT  TestAccSentinelAlertRuleNrt_basic
=== CONT  TestAccSentinelAlertRuleNrt_requiresImport
=== CONT  TestAccSentinelAlertRuleNrt_withAlertRuleTemplateGuid
=== CONT  TestAccSentinelAlertRuleNrt_update
=== CONT  TestAccSentinelAlertRuleNrt_complete
--- PASS: TestAccSentinelAlertRuleNrt_complete (160.15s)
--- PASS: TestAccSentinelAlertRuleNrt_basic (160.31s)
--- PASS: TestAccSentinelAlertRuleNrt_requiresImport (168.30s)
--- PASS: TestAccSentinelAlertRuleNrt_withAlertRuleTemplateGuid (177.06s)
--- PASS: TestAccSentinelAlertRuleNrt_update (229.71s)
PASS

Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🧾

katbyte added a commit that referenced this pull request Nov 6, 2022
@katbyte katbyte merged commit 3203c7e into hashicorp:main Nov 8, 2022
@github-actions github-actions bot added this to the v3.31.0 milestone Nov 8, 2022
@github-actions
Copy link

This functionality has been released in v3.31.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 11, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants