Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azurerm_monitor_diagnostic_setting - support partner_solution_id #19114

Merged
merged 2 commits into from
Nov 3, 2022

Conversation

teowa
Copy link
Contributor

@teowa teowa commented Nov 3, 2022

Resolves #19076

Ref:

  1. swagger
  2. Microsoft docs

Test:

make acctests SERVICE="monitor" TESTARGS="-parallel 20 -test.run=TestAccMonitorDiagnosticSetting_partnerSolution$" TESTTIMEOUT='1440m'
==> Checking that code complies with gofmt requirements...
==> Checking that Custom Timeouts are used...
==> Checking that acceptance test packages are used...
TF_ACC=1 go test -v ./internal/services/monitor -parallel 20 -test.run=TestAccMonitorDiagnosticSetting_partnerSolution$ -timeout 1440m -ldflags="-X=github.com/hashicorp/terraform-provider-azurerm/version.ProviderVersion=acc"
=== RUN   TestAccMonitorDiagnosticSetting_partnerSolution
=== PAUSE TestAccMonitorDiagnosticSetting_partnerSolution
=== CONT  TestAccMonitorDiagnosticSetting_partnerSolution
--- PASS: TestAccMonitorDiagnosticSetting_partnerSolution (568.74s)
PASS
ok      github.com/hashicorp/terraform-provider-azurerm/internal/services/monitor       568.774s

Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🍄

@katbyte katbyte merged commit 6ea7961 into hashicorp:main Nov 3, 2022
katbyte added a commit that referenced this pull request Nov 3, 2022
@github-actions github-actions bot added this to the v3.30.0 milestone Nov 3, 2022
@github-actions
Copy link

github-actions bot commented Nov 4, 2022

This functionality has been released in v3.30.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

github-actions bot commented Dec 7, 2022

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 7, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for partner solution on azurerm_monitor_diagnostic_setting
2 participants