Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azurerm_virtual_machine_extension azurerm_virtual_machine_scale_set_extension azurerm_*_virtual_machine_scale_set - support protected_settings_from_key_vault #19098

Merged
merged 1 commit into from
Nov 2, 2022

Conversation

myc2h6o
Copy link
Contributor

@myc2h6o myc2h6o commented Nov 2, 2022

  • Currently we have protected_settings which is a Json encoded string to specify secret value for a VM/VMSS extension. This change is to add the support for protected_settings_from_key_vault which allows the extension to read the protected settings from a Key Vault Secret instead.

  • Swagger:
    VM
    VMSS
    protectedSettingsFromKeyVault (KeyVaultSecretReference)

  • Affected resources:
    azurerm_virtual_machine_extension
    azurerm_virtual_machine_scale_set_extension
    azurerm_linux_virtual_machine_scale_set
    azurerm_windows_virtual_machine_scale_set
    azurerm_orchestrated_virtual_machine_scale_set

…t_extension` `azurerm_*_virtual_machine_scale_set` - support `protected_settings_from_key_vault`
Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🌩️

@katbyte katbyte merged commit ad63926 into hashicorp:main Nov 2, 2022
@github-actions github-actions bot added this to the v3.30.0 milestone Nov 2, 2022
katbyte added a commit that referenced this pull request Nov 2, 2022
@myc2h6o myc2h6o deleted the vm_ext_kv branch November 3, 2022 02:47
@github-actions
Copy link

github-actions bot commented Nov 4, 2022

This functionality has been released in v3.30.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

github-actions bot commented Dec 5, 2022

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 5, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants