Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azurerm_eventhub_namespace_disaster_recovery_config: fixing breaking pair logic #19030

Merged
merged 1 commit into from
Oct 31, 2022

Conversation

xiaxyi
Copy link
Contributor

@xiaxyi xiaxyi commented Oct 28, 2022

When updating the partner_namespace_id or deleting the DCR, Terraform will try to break pair between two namespaces, however, if the pair is broke already, the operation will fail.

The issue is breaking pair operation cannot be done from terraform due to bug mentioned here, which means, the change can only be made outside of TF. If we don't add a logic to check the existence of the partner namespace, the DCR cannot be deleted/ updated if user breaks the pair via other ways.

@github-actions github-actions bot added the service/event-hubs EventHubs label Oct 28, 2022
Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎱

@katbyte katbyte merged commit d8181e5 into hashicorp:main Oct 31, 2022
@github-actions github-actions bot added this to the v3.30.0 milestone Oct 31, 2022
katbyte added a commit that referenced this pull request Oct 31, 2022
@github-actions
Copy link

github-actions bot commented Nov 4, 2022

This functionality has been released in v3.30.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

github-actions bot commented Dec 5, 2022

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 5, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants