Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent potential crash due to empty name in VNet data source #1898

Merged
merged 1 commit into from
Sep 8, 2018

Conversation

JunyiYi
Copy link

@JunyiYi JunyiYi commented Sep 8, 2018

  • Add non-empty check for name field
  • Replace resource_group_name with common definition to match best practice

This PR resolves #966 .

@JunyiYi JunyiYi self-assigned this Sep 8, 2018
@ghost ghost added the size/S label Sep 8, 2018
Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @JunyiYi,

Thank you for the fixe, this LGTM 👍

@katbyte katbyte added this to the 1.15.0 milestone Sep 8, 2018
@katbyte katbyte merged commit 8e8e100 into master Sep 8, 2018
@katbyte katbyte deleted the dsvnet_emptyname branch September 8, 2018 17:18
katbyte added a commit that referenced this pull request Sep 8, 2018
@ghost
Copy link

ghost commented Mar 6, 2019

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Empty string value for required data source argument causes crash
2 participants