Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azurerm_stream_analytics_stream_input_eventhub - Mark shared_access_policy_key and shared_access_policy_name as optional #18959

Merged
merged 3 commits into from
Oct 26, 2022

Conversation

neil-yechenwei
Copy link
Contributor

@neil-yechenwei neil-yechenwei commented Oct 25, 2022

fixes #18940

--- PASS: TestAccStreamAnalyticsStreamInputEventHub_csv (382.21s)
--- PASS: TestAccStreamAnalyticsStreamInputEventHub_avro (426.81s)
--- PASS: TestAccStreamAnalyticsStreamInputEventHub_json (441.21s)
--- PASS: TestAccStreamAnalyticsStreamInputEventHub_noOptional (441.21s)
--- PASS: TestAccStreamAnalyticsStreamInputEventHub_requiresImport (478.98s)
--- PASS: TestAccStreamAnalyticsStreamInputEventHub_update (804.22s)
--- PASS: TestAccStreamAnalyticsStreamInputEventHub_authenticationMode (419.38s)
--- PASS: TestAccStreamAnalyticsStreamInputEventHub_msiWithoutSharedAccessPolicy (432.19s)

image

…olicy_key and shared_access_policy_name as optional
@stephybun stephybun added the bug label Oct 26, 2022
Copy link
Member

@stephybun stephybun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @neil-yechenwei LGTM 👍

@stephybun stephybun merged commit 4a175f2 into hashicorp:main Oct 26, 2022
@github-actions github-actions bot added this to the v3.29.0 milestone Oct 26, 2022
stephybun added a commit that referenced this pull request Oct 26, 2022
@github-actions
Copy link

This functionality has been released in v3.29.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MSI support azurerm_stream_analytics_stream_input_eventhub should not require shared_access_policy_* arguments
3 participants