New resources: `azurerm_iothub_device_update_account` `azurerm_iothub_device_update_instance` #18789

myc2h6o · 2022-10-17T02:00:16Z

Adding the support for these two new resources for IoT Hub Resource Management: https://learn.microsoft.com/azure/iot-hub-device-update/create-device-update-account
Swagger: https://github.com/Azure/azure-rest-api-specs/blob/main/specification/deviceupdate/resource-manager/Microsoft.DeviceUpdate/stable/2022-10-01/deviceupdate.json
These two resources are part of IoT Hub Management, so I put them under the iothub directory
IoT Hub Device Update is not available in westeurope, so updating the teamcity locations with northeurope instead

…_device_update_instance`

stephybun

Thanks for this PR @myc2h6o, there are still some test failures relating to the region though

------- Stdout: -------
=== RUN   TestAccIotHubDeviceUpdateAccount_sku
=== PAUSE TestAccIotHubDeviceUpdateAccount_sku
=== CONT  TestAccIotHubDeviceUpdateAccount_sku
testcase.go:110: Step 1/4 error: Error running apply: exit status 1
Error: creating Account (Subscription: "*******"
Resource Group Name: "acctest-rg-221018105259715989"
Account Name: "acc-dua-eu3sy"): performing AccountsCreate: deviceupdates.DeviceupdatesClient#AccountsCreate: Failure sending request: StatusCode=0 -- Original Error: Code="LocationNotAvailableForResourceType" Message="The provided location 'westeurope' is not available for resource type 'Microsoft.DeviceUpdate/accounts'. List of available regions for the resource type is 'westus2,northeurope,southeastasia,eastus,eastus2,southcentralus,swedencentral,uksouth,westus3'."
with azurerm_iothub_device_update_account.test,
on terraform_plugin_test.tf line 13, in resource "azurerm_iothub_device_update_account" "test":
13: resource "azurerm_iothub_device_update_account" "test" {
creating Account (Subscription: "*******"
Resource Group Name: "acctest-rg-221018105259715989"
Account Name: "acc-dua-eu3sy"): performing AccountsCreate:
deviceupdates.DeviceupdatesClient#AccountsCreate: Failure sending request:
StatusCode=0 -- Original Error: Code="LocationNotAvailableForResourceType"
Message="The provided location 'westeurope' is not available for resource
type 'Microsoft.DeviceUpdate/accounts'. List of available regions for the
resource type is
'westus2,northeurope,southeastasia,eastus,eastus2,southcentralus,swedencentral,uksouth,westus3'."
--- FAIL: TestAccIotHubDeviceUpdateAccount_sku (120.85s)
FAIL

myc2h6o · 2022-10-19T09:26:15Z

Hi @stephybun thanks for reviewing the pr! I've already updated the region here: https://github.com/hashicorp/terraform-provider-azurerm/pull/18789/files#diff-c9a4f5ece9fe921f274cae0220ba39a13027c503c6bd80e3cc9ee926565a5c94, to replace the westeurope with northeurope, however the test seems to be run within westeurope still. Does it require the change to be merged to allow the config to take effect or am I doing something wrong there?

The test runs well with overriden parameter:

myc2h6o · 2022-10-20T07:01:54Z

Hi @stephybun I've double checked, looks like the .teamcity location settings only take effect after merged. I've split out the test location change to #18884

myc2h6o · 2022-10-21T16:13:54Z

The separate pr for updating test location is working fine. Here is the updated test result

jackofallops

Thanks @myc2h6o
The update methods I think need revisiting. The removal of the data from the payloads there is an anti-pattern that shouldn't be necessary and we should avoid within the provider. Can you speak with the service team on your side to resolve?

Thanks!

jackofallops · 2022-10-24T11:03:58Z

internal/services/iothub/iothub_device_update_account_resource.go

+			existing.Properties.HostName = nil
+			existing.Properties.Locations = nil
+			existing.SystemData = nil


This shouldn't need to be zeroed, ARM spec says the service is supposed to ignore R/O fields on update payloads? Needing this would indicated a bug?

jackofallops · 2022-10-24T11:34:50Z

internal/services/iothub/iothub_device_update_instance_resource.go

+				existing.Tags = &model.Tags
+			}
+
+			existing.SystemData = nil


As above, this shouldn't be necessary.

jackofallops · 2022-10-24T11:37:11Z

internal/services/iothub/validate/iot_hub_device_update_instance_name.go

+	}
+
+	if matched := regexp.MustCompile(`^[A-Za-z0-9]+(-[A-Za-z0-9]+)*$`).Match([]byte(value)); !matched {
+		errors = append(errors, fmt.Errorf("%q may only contain alphanumeric characters and dashes, and consecutive dashes (-) are not allowed", k))


Suggested change

errors = append(errors, fmt.Errorf("%q may only contain alphanumeric characters and dashes, and consecutive dashes (-) are not allowed", k))

errors = append(errors, fmt.Errorf("%q must start with an alphanumeric, may only contain alphanumeric characters and dashes, and consecutive dashes (-) are not allowed", k))

Error message updated.

myc2h6o · 2022-10-25T01:21:36Z

Hi @jackofallops thanks for reviewing the pr! I've updated the error message, and removed the unexpected assignment of HostName and Locations in the Update function.
As for SystemData, it is a workaround before the Pandora side fix hashicorp/pandora#1096 is done, similar to signalr_service, I've added comment around the code.

myc2h6o · 2022-10-25T02:17:41Z

Test result after the update

katbyte · 2022-10-26T21:22:46Z

website/docs/r/iothub_device_update_account.html.markdown

+
+* `identity` - (Optional) An `identity` block as defined below.
+
+* `public_network_access` - (Optional) The Public Network Access setting of the IoT Hub Device Update Account. Possible values are `Enabled` and `Disabled`. Defaults to `Enabled`.


this is a bool?

Suggested change

* `public_network_access` - (Optional) The Public Network Access setting of the IoT Hub Device Update Account. Possible values are `Enabled` and `Disabled`. Defaults to `Enabled`.

* `public_network_access_enabled` - (Optional) The Public Network Access setting of the IoT Hub Device Update Account. Possible values are `Enabled` and `Disabled`. Defaults to `Enabled`.

katbyte · 2022-10-26T21:23:13Z

website/docs/r/iothub_device_update_instance.html.markdown

+
+* `name` - (Required) Specifies the name which should be used for this IoT Hub Device Update Instance. Changing this forces a new resource to be created.
+
+* `iothub_device_update_account_id` - (Required) Specifies the ID of the IoT Hub Device Update Account where the IoT Hub Device Update Instance exists. Changing this forces a new resource to be created.


iothub is in the rsource name so

Suggested change

* `iothub_device_update_account_id` - (Required) Specifies the ID of the IoT Hub Device Update Account where the IoT Hub Device Update Instance exists. Changing this forces a new resource to be created.

* `device_update_account_id` - (Required) Specifies the ID of the IoT Hub Device Update Account where the IoT Hub Device Update Instance exists. Changing this forces a new resource to be created.

myc2h6o · 2022-10-27T02:54:55Z

Hi @katbyte thanks for reviewing the pr! I've renamed iothub_device_update_account_id to device_update_account_id and public_network_access (string) to public_network_access_enabled (bool). Also simplified some test cases. Please take a look.

katbyte

Thanks @myc2h6o - LGTM 🗺️

github-actions · 2022-10-28T00:14:06Z

This functionality has been released in v3.29.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

github-actions · 2022-11-28T02:18:39Z

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

github-actions bot added dependencies documentation service/iot-hub labels Oct 17, 2022

myc2h6o force-pushed the device_update branch 3 times, most recently from 03e8048 to 2f3f508 Compare October 17, 2022 05:48

New resources: azurerm_iothub_device_update_account `azurerm_iothub…

1b75770

…_device_update_instance`

myc2h6o force-pushed the device_update branch from 2f3f508 to 1b75770 Compare October 17, 2022 06:38

stephybun reviewed Oct 18, 2022

View reviewed changes

stephybun added the new-resource label Oct 18, 2022

github-actions bot added the waiting-response label Oct 18, 2022

github-actions bot removed the waiting-response label Oct 19, 2022

myc2h6o mentioned this pull request Oct 20, 2022

iothub - Update test location to fit Device Update resource #18884

Merged

jackofallops requested changes Oct 24, 2022

View reviewed changes

github-actions bot added the waiting-response label Oct 24, 2022

resolve comments

da8755f

github-actions bot removed the waiting-response label Oct 25, 2022

katbyte requested changes Oct 26, 2022

View reviewed changes

github-actions bot added waiting-response and removed waiting-response labels Oct 26, 2022

resolve comment

cde3fd0

myc2h6o force-pushed the device_update branch from 2060108 to cde3fd0 Compare October 27, 2022 02:57

katbyte approved these changes Oct 27, 2022

View reviewed changes

katbyte merged commit 74b3cbd into hashicorp:main Oct 27, 2022

katbyte added a commit that referenced this pull request Oct 27, 2022

CHANGELOG #18789

76c9c16

github-actions bot added this to the v3.29.0 milestone Oct 27, 2022

myc2h6o deleted the device_update branch October 28, 2022 13:57

github-actions bot locked as resolved and limited conversation to collaborators Nov 28, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

New resources: `azurerm_iothub_device_update_account` `azurerm_iothub_device_update_instance` #18789

New resources: `azurerm_iothub_device_update_account` `azurerm_iothub_device_update_instance` #18789

myc2h6o commented Oct 17, 2022 •

edited

Loading

stephybun left a comment

myc2h6o commented Oct 19, 2022

myc2h6o commented Oct 20, 2022

myc2h6o commented Oct 21, 2022

jackofallops left a comment

jackofallops Oct 24, 2022

jackofallops Oct 24, 2022

jackofallops Oct 24, 2022

myc2h6o Oct 25, 2022

myc2h6o commented Oct 25, 2022

myc2h6o commented Oct 25, 2022

katbyte Oct 26, 2022

katbyte Oct 26, 2022

myc2h6o commented Oct 27, 2022

katbyte left a comment

github-actions bot commented Oct 28, 2022

github-actions bot commented Nov 28, 2022

	errors = append(errors, fmt.Errorf("%q may only contain alphanumeric characters and dashes, and consecutive dashes (-) are not allowed", k))
	errors = append(errors, fmt.Errorf("%q must start with an alphanumeric, may only contain alphanumeric characters and dashes, and consecutive dashes (-) are not allowed", k))


		* `identity` - (Optional) An `identity` block as defined below.

		* `public_network_access` - (Optional) The Public Network Access setting of the IoT Hub Device Update Account. Possible values are `Enabled` and `Disabled`. Defaults to `Enabled`.

	* `public_network_access` - (Optional) The Public Network Access setting of the IoT Hub Device Update Account. Possible values are `Enabled` and `Disabled`. Defaults to `Enabled`.
	* `public_network_access_enabled` - (Optional) The Public Network Access setting of the IoT Hub Device Update Account. Possible values are `Enabled` and `Disabled`. Defaults to `Enabled`.


		* `name` - (Required) Specifies the name which should be used for this IoT Hub Device Update Instance. Changing this forces a new resource to be created.

		* `iothub_device_update_account_id` - (Required) Specifies the ID of the IoT Hub Device Update Account where the IoT Hub Device Update Instance exists. Changing this forces a new resource to be created.

	* `iothub_device_update_account_id` - (Required) Specifies the ID of the IoT Hub Device Update Account where the IoT Hub Device Update Instance exists. Changing this forces a new resource to be created.
	* `device_update_account_id` - (Required) Specifies the ID of the IoT Hub Device Update Account where the IoT Hub Device Update Instance exists. Changing this forces a new resource to be created.

New resources: azurerm_iothub_device_update_account azurerm_iothub_device_update_instance #18789

New resources: azurerm_iothub_device_update_account azurerm_iothub_device_update_instance #18789

Conversation

myc2h6o commented Oct 17, 2022 • edited Loading

stephybun left a comment

Choose a reason for hiding this comment

myc2h6o commented Oct 19, 2022

myc2h6o commented Oct 20, 2022

myc2h6o commented Oct 21, 2022

jackofallops left a comment

Choose a reason for hiding this comment

jackofallops Oct 24, 2022

Choose a reason for hiding this comment

jackofallops Oct 24, 2022

Choose a reason for hiding this comment

jackofallops Oct 24, 2022

Choose a reason for hiding this comment

myc2h6o Oct 25, 2022

Choose a reason for hiding this comment

myc2h6o commented Oct 25, 2022

myc2h6o commented Oct 25, 2022

katbyte Oct 26, 2022

Choose a reason for hiding this comment

katbyte Oct 26, 2022

Choose a reason for hiding this comment

myc2h6o commented Oct 27, 2022

katbyte left a comment

Choose a reason for hiding this comment

github-actions bot commented Oct 28, 2022

github-actions bot commented Nov 28, 2022

New resources: `azurerm_iothub_device_update_account` `azurerm_iothub_device_update_instance` #18789

New resources: `azurerm_iothub_device_update_account` `azurerm_iothub_device_update_instance` #18789

myc2h6o commented Oct 17, 2022 •

edited

Loading