Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azurerm_firewall_policy_rule_collection_group - limit dnat rule destination port max number to 1 #18766

Merged
merged 3 commits into from
Oct 19, 2022

Conversation

wuxu92
Copy link
Contributor

@wuxu92 wuxu92 commented Oct 14, 2022

Fixes: #18725

I have reproduced this bug locally, looks like a server-side limitation on this parameter. the detailed error message is below. so I simply add a MaxItem limit to it so it is exposed in the terraform plan stage. This looks like breaking change, Or should we only update the document but not add the MaxItems limit in the code?

{
    "error": {
        "code": "FirewallPolicyNatRuleInvalidDnatMultipleDestinationPortsExists",
        "message": "Firewall Policy Nat Rule Collection: nat_rule_collection1 Rule: nat_rule_collection1_rule1 has Multiple Destination Ports on a DNAT Rule. This is not supported, please set only 1 destination port on this rule."
    },
    "status": "Failed"
}

cc @neil-yechenwei if you know more context about this feature? I found you have worked on this before, Thanks.

Co-authored-by: stephybun <[email protected]>
Copy link
Member

@stephybun stephybun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @wuxu92 LGTM 🐞

@stephybun stephybun merged commit b0af84a into hashicorp:main Oct 19, 2022
@github-actions github-actions bot added this to the v3.28.0 milestone Oct 19, 2022
stephybun added a commit that referenced this pull request Oct 19, 2022
@github-actions
Copy link

This functionality has been released in v3.28.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 24, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorrect argument type for destination_ports on nat_rule_collection's
2 participants