-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
azurerm_servicebus_namespace_disaster_recovery_config
: support alias_authorization_rule_id
#18729
Conversation
@@ -50,6 +51,12 @@ func dataSourceServiceBusNamespaceDisasterRecoveryConfig() *pluginsdk.Resource { | |||
AtLeastOneOf: []string{"namespace_id", "resource_group_name", "namespace_name"}, | |||
}, | |||
|
|||
"auth_rule_id_of_the_alias": { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this would be better as
"auth_rule_id_of_the_alias": { | |
"alias_authorization_rule_id": { |
Thanks @katbyte , updated the property name |
azurerm_servicebus_namespace_disaster_recovery_config
: add shared access policy propertyazurerm_servicebus_namespace_disaster_recovery_config
: support alias_authorization_rule_id
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @xiaxyi - LGTM 🔐
This functionality has been released in v3.29.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions. |
The dr alias connection string should be accessed by specifying the shared access policy which is having a default value
RootManageSharedAccessKey
, instead of using the alias name directly.fix failed acc tests"
testcase.go:110: Step 1/1 error: Check failed: Check 4/7 error: data.azurerm_servicebus_namespace_disaster_recovery_config.test: Attribute 'primary_connection_string_alias' expected to be set
in this pr, also add importSteps in test cases for servicebus
fix #18743