Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azurerm_servicebus_namespace_disaster_recovery_config: support alias_authorization_rule_id #18729

Merged
merged 5 commits into from
Oct 24, 2022

Conversation

xiaxyi
Copy link
Contributor

@xiaxyi xiaxyi commented Oct 13, 2022

The dr alias connection string should be accessed by specifying the shared access policy which is having a default value RootManageSharedAccessKey, instead of using the alias name directly.

fix failed acc tests"
testcase.go:110: Step 1/1 error: Check failed: Check 4/7 error: data.azurerm_servicebus_namespace_disaster_recovery_config.test: Attribute 'primary_connection_string_alias' expected to be set

in this pr, also add importSteps in test cases for servicebus

fix #18743

@@ -50,6 +51,12 @@ func dataSourceServiceBusNamespaceDisasterRecoveryConfig() *pluginsdk.Resource {
AtLeastOneOf: []string{"namespace_id", "resource_group_name", "namespace_name"},
},

"auth_rule_id_of_the_alias": {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this would be better as

Suggested change
"auth_rule_id_of_the_alias": {
"alias_authorization_rule_id": {

@xiaxyi
Copy link
Contributor Author

xiaxyi commented Oct 14, 2022

Thanks @katbyte , updated the property name

@katbyte katbyte changed the title azurerm_servicebus_namespace_disaster_recovery_config: add shared access policy property azurerm_servicebus_namespace_disaster_recovery_config: support alias_authorization_rule_id Oct 24, 2022
Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @xiaxyi - LGTM 🔐

@katbyte katbyte merged commit 16ce6b9 into hashicorp:main Oct 24, 2022
katbyte added a commit that referenced this pull request Oct 24, 2022
@github-actions github-actions bot added this to the v3.29.0 milestone Oct 24, 2022
@github-actions
Copy link

This functionality has been released in v3.29.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ServiceBus Geo Replication Resource returning null value for alias attributes
2 participants