Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

azurerm_kubernetes_cluster - support for the web_app_routing property #18667

Merged
merged 5 commits into from
Oct 28, 2022
Merged

azurerm_kubernetes_cluster - support for the web_app_routing property #18667

merged 5 commits into from
Oct 28, 2022

Conversation

ms-henglu
Copy link
Contributor 

=== RUN   TestAccKubernetesCluster_webAppRouting
=== PAUSE TestAccKubernetesCluster_webAppRouting
=== CONT  TestAccKubernetesCluster_webAppRouting
--- PASS: TestAccKubernetesCluster_webAppRouting (1047.24s)
PASS

@ms-henglu ms-henglu changed the title azurerm_kubernetes_cluster - web_app_routing azurerm_kubernetes_cluster - support for the web_app_routing property Oct 9, 2022
stephybun
stephybun reviewed Oct 12, 2022
View reviewed changes
Copy link
Member

@stephybun stephybun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this @ms-henglu, a few minor comments, but once they're resolved this should be good to go!

@stephybun stephybun linked an issue Oct 12, 2022 that may be closed by this pull request
Support for AKS Web Application Routing add-on #18386
Closed
1 task
@stephybun stephybun mentioned this pull request Oct 12, 2022
Closed
@ms-henglu ms-henglu force-pushed the branch-221009-aks-supports-web-app-routing branch from 45cb3a1 to 2fffaef Compare October 14, 2022 02:51
@ms-henglu ms-henglu changed the title azurerm_kubernetes_cluster - support for the web_app_routing property [WIP]azurerm_kubernetes_cluster - support for the web_app_routing property Oct 14, 2022
@ms-henglu ms-henglu changed the title [WIP]azurerm_kubernetes_cluster - support for the web_app_routing property azurerm_kubernetes_cluster - support for the web_app_routing property Oct 17, 2022
@ms-henglu ms-henglu requested review from stephybun and removed request for stephybun October 17, 2022 05:31
stephybun
stephybun reviewed Oct 17, 2022
View reviewed changes
internal/services/containers/kubernetes_cluster_resource.go Outdated
Schema: map[string]*pluginsdk.Schema{
"dns_zone_id": {
Type: pluginsdk.TypeString,
Optional: true,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it a valid use case/configuration for this to be left blank?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I've confirmed with service team.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If it's omitted then the dns_zone_id is set to an empty string "". Where are the DNS entries created for applications that are deployed to the cluster?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From service team:

Probably no dns entries created automatically.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Then this should be marked as Required.

@aristosvo aristosvo mentioned this pull request Oct 18, 2022
Merged
stephybun
stephybun requested changes Oct 26, 2022
View reviewed changes
internal/services/containers/kubernetes_cluster_resource.go Outdated
Schema: map[string]*pluginsdk.Schema{
"dns_zone_id": {
Type: pluginsdk.TypeString,
Optional: true,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Then this should be marked as Required.

stephybun
stephybun approved these changes Oct 28, 2022
View reviewed changes
Copy link
Member

@stephybun stephybun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ms-henglu LGTM 🥟

@stephybun stephybun merged commit b18dd8f into hashicorp:main Oct 28, 2022
@github-actions github-actions bot added this to the v3.30.0 milestone Oct 28, 2022
stephybun added a commit that referenced this pull request Oct 28, 2022
@stephybun
Update for #18667
5cc4cf7
@github-actions
Copy link

github-actions bot commented Nov 4, 2022

This functionality has been released in v3.30.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

github-actions bot commented Dec 5, 2022

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 5, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@stephybun stephybun stephybun approved these changes

Assignees
No one assigned
Labels
documentation enhancement service/kubernetes-cluster
Projects
None yet
Milestone
v3.30.0
Development

Successfully merging this pull request may close these issues.

Support for AKS Web Application Routing add-on
3 participants
@ms-henglu @stephybun @katbyte