Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Data Lake Store File: updating the ID #1856

Merged
merged 4 commits into from
Sep 1, 2018
Merged

Conversation

tombuildsstuff
Copy link
Contributor

@tombuildsstuff tombuildsstuff commented Aug 31, 2018

Updates the ID for the Data Lake Store File so that we have all of the information required to import it.

We also expose the endpoint for the Data Lake Store Account since this is useful.

This is a dependency for #1746

```
 $ acctests azurerm TestAccAzureRMDataLakeStoreFileMigrateState
=== RUN   TestAccAzureRMDataLakeStoreFileMigrateState
2018/08/31 18:59:29 [INFO] Found AzureRM Data Lake Store File State v0; migrating to v1
2018/08/31 18:59:29 [DEBUG] ARM Data Lake Store File Attributes before Migration: map[string]string{"account_name":"example", "remote_file_path":"/test/blob.vhd"}
2018/08/31 18:59:29 [DEBUG] ARM Data Lake Store File Attributes after State Migration: map[string]string{"remote_file_path":"/test/blob.vhd", "account_name":"example", "id":"example.azuredatalakestore.net/test/blob.vhd"}
--- PASS: TestAccAzureRMDataLakeStoreFileMigrateState (0.00s)
PASS
ok  	github.com/terraform-providers/terraform-provider-azurerm/azurerm	0.411s
```
Copy link
Member

@mbfrahry mbfrahry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are we looking to support import with this PR?

@mbfrahry
Copy link
Member

Hitting errors

--- FAIL: TestAccAzureRMDataLakeStoreFile_basic (74.39s)
	testing.go:513: Step 0 error: Error applying: 1 error(s) occurred:

		* azurerm_data_lake_store_file.test: 1 error(s) occurred:

		* azurerm_data_lake_store_file.test: Error making Read request on Azure Data Lake Store File "unlikely23exst2acctexrp.azuredatalakestore.net/test/application_gateway_test.cer" (Account "unlikely23exst2acctexrp/test/application_gateway_test.cer"): filesystem.Client#GetFileStatus: Failure sending request: StatusCode=0 -- Original Error: Get https://unlikely23exst2acctexrp/test/application_gateway_test.cer.azuredatalakestore.net/webhdfs/v1/unlikely23exst2acctexrp.azuredatalakestore.net%2Ftest%2Fapplication_gateway_test.cer?api-version=2016-11-01&op=GETFILESTATUS&tooId=true: dial tcp: lookup unlikely23exst2acctexrp: no such host

Copy link
Member

@mbfrahry mbfrahry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@tombuildsstuff
Copy link
Contributor Author

Tests pass:

screenshot 2018-09-01 at 14 30 44

@tombuildsstuff tombuildsstuff merged commit 5c7dd38 into master Sep 1, 2018
@tombuildsstuff tombuildsstuff deleted the data-lake-store-file branch September 1, 2018 13:31
tombuildsstuff added a commit that referenced this pull request Sep 1, 2018
@ghost
Copy link

ghost commented Mar 30, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 30, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants