azurerm_automation_software_update_configuration - fix windows update classification use a comma separate string

[wuxu92]

swagger definition as a comma-separated string

"includedUpdateClassifications": {
  "description": "Update classification included in the software update configuration. A comma separated string with required values",
  "type": "string",
  "enum": [
  "Unclassified",

https://github.com/Azure/azure-rest-api-specs/blob/99977890f7a2e8cf9b4e229f452c1af7b30184e4/specification/automation/resource-manager/Microsoft.Automation/stable/2019-06-01/softwareUpdateConfiguration.json#L400

--- PASS: TestAccSoftwareUpdateConfiguration_basic (166.01s)
--- PASS: TestAccSoftwareUpdateConfiguration_update (125.49s)
--- PASS: TestAccSoftwareUpdateConfiguration_windows (160.53s)
PASS

Fixes: #18537

[katbyte]

As this is supposed to be a list, and this property is misnamed can we deprecate this and create a new property classifications_included that takes a list and translates it to a CSV list for the api?

[wuxu92]

I have tried with a new property but we have to make it compatible with the deprecated one or there will be diff in the terraform plan. So I have to set both properties as Computed: true to ignore the diff. I don't think it's a so good solution. Is there better practice for this scenario?

[katbyte]

yes you will need to set both to computed, always set both, make them conflict, and the use the one that is set. that is the right way to deprecate.

[katbyte]

LGTM 🧄

[github-actions]

This functionality has been released in v3.25.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.