Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

virtual_machine_extension virtual_machine_scale_set_extension - support for failure_suppression_enabled #18441

Merged
merged 1 commit into from
Sep 21, 2022

Conversation

myc2h6o
Copy link
Contributor

@myc2h6o myc2h6o commented Sep 19, 2022

To add support for failure_suppression_enabled to the extracted resource. This was added to VMSS earlier

* `failure_suppression_enabled` - (Optional) Should failures from the extension be suppressed? Possible values are `true` or `false`. Defaults to `false`.
-> **NOTE:** Operational failures such as not connecting to the VM will not be suppressed regardless of the `failure_suppression_enabled` value.

@myc2h6o
Copy link
Contributor Author

myc2h6o commented Sep 19, 2022

Test result
image

Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎩

@katbyte katbyte merged commit ed59f41 into hashicorp:main Sep 21, 2022
@github-actions github-actions bot added this to the v3.24.0 milestone Sep 21, 2022
katbyte added a commit that referenced this pull request Sep 21, 2022
@myc2h6o myc2h6o deleted the extension_suppress_failure branch September 21, 2022 02:47
@github-actions
Copy link

This functionality has been released in v3.24.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 25, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants