Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azurerm_linux/windows_function_app_slot - Read correct appsettings #18396

Merged
merged 1 commit into from
Oct 3, 2022

Conversation

cek-cek
Copy link
Contributor

@cek-cek cek-cek commented Sep 15, 2022

Read slot's application settings instead of parent resource's to prevent unintended modification of slot settings during resource update.

Fixes #18274

@cek-cek cek-cek changed the title azurerm_linux/windows_function_app_slot - Read correct appsettings azurerm_linux/windows_function_app_slot - Read correct appsettings Sep 15, 2022
Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @cek-cek - LGTM 🍄

@KenticoMartinS
Copy link

Hi, please is there any estimate of when this will be merged? This fix seems to be ok, however, we are already waiting 15 days for this PR to be closed.

@katbyte
Copy link
Collaborator

katbyte commented Oct 3, 2022

Sorry @KenticoMartinS ! this totally slipped through my scripts merging now

@katbyte katbyte merged commit e868523 into hashicorp:main Oct 3, 2022
@github-actions github-actions bot added this to the v3.26.0 milestone Oct 3, 2022
katbyte added a commit that referenced this pull request Oct 3, 2022
@github-actions
Copy link

This functionality has been released in v3.26.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@cek-cek cek-cek deleted the az-appslot-appsettings-update branch October 24, 2022 14:18
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 24, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

azurerm_linux_function_app_slot: WEBSITE_CONTENTSHARE get overwritten on update
3 participants