New resource: `azurerm_orbital_contact_profile` #18317

jiaweitao001 · 2022-09-09T03:07:37Z

All tests passed.

Test results:

--- PASS: TestAccContactProfile_basic (290.56s)
--- PASS: TestAccContactProfile_complete (377.92s)
--- PASS: TestAccContactProfile_update (385.53s)
PASS
ok      github.com/hashicorp/terraform-provider-azurerm/internal/services/orbital       400.348s

website/docs/r/orbital_contact_profile.html.markdown

katbyte · 2022-09-09T03:11:26Z

website/docs/r/orbital_contact_profile.html.markdown

+* `modulation_configuration` - (Optional) Copy of the modem configuration file such as Kratos QRadio. Only valid for uplink directions. If provided, the modem connects to the customer endpoint and accepts commands from the customer instead of a VITA.49 stream.
+
+* `demodulation_configuration` - (Optional) Copy of the modem configuration file such as Kratos QRadio or Kratos QuantumRx. Only valid for downlink directions. If provided, the modem connects to the customer endpoint and sends demodulated data instead of a VITA.49 stream.


should this be

Suggested change

* `modulation_configuration` - (Optional) Copy of the modem configuration file such as Kratos QRadio. Only valid for uplink directions. If provided, the modem connects to the customer endpoint and accepts commands from the customer instead of a VITA.49 stream.

* `demodulation_configuration` - (Optional) Copy of the modem configuration file such as Kratos QRadio or Kratos QuantumRx. Only valid for downlink directions. If provided, the modem connects to the customer endpoint and sends demodulated data instead of a VITA.49 stream.

* `modem_modulation_file_content` - (Optional) Copy of the modem configuration file such as Kratos QRadio. Only valid for uplink directions. If provided, the modem connects to the customer endpoint and accepts commands from the customer instead of a VITA.49 stream.

* `modem_demodulation_file_content` - (Optional) Copy of the modem configuration file such as Kratos QRadio or Kratos QuantumRx. Only valid for downlink directions. If provided, the modem connects to the customer endpoint and sends demodulated data instead of a VITA.49 stream.

the test config seems like they are a constant?

Same as commented above. Will double check with service team.

internal/services/orbital/contact_profile_resource_test.go

website/docs/r/orbital_contact_profile.html.markdown

katbyte

may need to change this services tes regions in tc config:

------- Stdout: -------
=== RUN   TestAccContactProfile_basic
=== PAUSE TestAccContactProfile_basic
=== CONT  TestAccContactProfile_basic
    testcase.go:110: Step 1/2 error: Error running apply: exit status 1
        
        Error: creating Contact Profile (Subscription: "*******"
        Resource Group Name: "acctestRG-220913031041386609"
        Contact Profile Name: "testcontactprofile-220913031041386609"): contactprofile.ContactProfileClient#ContactProfilesCreateOrUpdate: Failure sending request: StatusCode=0 -- Original Error: Code="LocationNotAvailableForResourceType" Message="The provided location 'westeurope' is not available for resource type 'Microsoft.Orbital/contactProfiles'. List of available regions for the resource type is 'westus2,westus3,westus,eastus,southcentralus,norwayeast,australiaeast,swedencentral'."
        
          with azurerm_orbital_contact_profile.test,
          on terraform_plugin_test.tf line 41, in resource "azurerm_orbital_contact_profile" "test":
          41: resource "azurerm_orbital_contact_profile" "test" {
        
        creating Contact Profile (Subscription:
        "*******"
        Resource Group Name: "acctestRG-220913031041386609"
        Contact Profile Name: "testcontactprofile-220913031041386609"):
        contactprofile.ContactProfileClient#ContactProfilesCreateOrUpdate: Failure
        sending request: StatusCode=0 -- Original Error:
        Code="LocationNotAvailableForResourceType" Message="The provided location
        'westeurope' is not available for resource type
        'Microsoft.Orbital/contactProfiles'. List of available regions for the
        resource type is
        'westus2,westus3,westus,eastus,southcentralus,norwayeast,australiaeast,swedencentral'."
--- FAIL: TestAccContactProfile_basic (168.94s)
FAIL

katbyte · 2022-09-13T15:48:55Z

internal/services/orbital/contact_profile_resource.go

+		"location": azure.SchemaLocation(),
+
+		"links": ContactProfileLinkSchema(),


is there a reason you are pulling these out?

Yes. This is schema has a nested structure, I'm pulling it out for better code readability.

unless it is reused we should not be doing this

internal/services/orbital/contact_profile_resource_test.go

jiaweitao001 · 2022-09-15T04:45:09Z

Hi @katbyte , update from service team encoding_configuration and decoding_configuration are currently unused, removed from this PR.

katbyte · 2022-09-24T02:50:21Z

internal/services/orbital/contact_profile_resource.go

+		"location": azure.SchemaLocation(),
+
+		"links": ContactProfileLinkSchema(),


unless it is reused we should not be doing this

internal/services/orbital/helper.go

website/docs/r/orbital_contact_profile.html.markdown

katbyte · 2022-09-24T02:54:06Z

internal/services/orbital/contact_profile_resource_test.go

+      demodulation_configuration = "na"
+      modulation_configuration   = "AQUA_UPLINK_BPSK"


these seem to just take a constant? so

Suggested change

demodulation_configuration = "na"

modulation_configuration = "AQUA_UPLINK_BPSK"

demodulation_type = "na"

modulation_type = "AQUA_UPLINK_BPSK"

configuration seems wrong for what takes a constant

According to service team, these are not constants.

internal/services/orbital/helper.go

katbyte

LGTM 🍰

github-actions · 2022-10-14T01:32:14Z

This functionality has been released in v3.27.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

github-actions · 2022-11-13T02:30:47Z

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

New resource: azurerm_orbital_contact_profile

ff1549a

github-actions bot added the documentation label Sep 9, 2022

katbyte requested changes Sep 9, 2022

View reviewed changes

github-actions bot added waiting-response and removed waiting-response labels Sep 9, 2022

renaming variables

2e4ad21

jiaweitao001 requested a review from katbyte September 13, 2022 05:03

katbyte requested changes Sep 13, 2022

View reviewed changes

github-actions bot added waiting-response and removed waiting-response labels Sep 13, 2022

Removing unused parameters

08e740d

jiaweitao001 requested a review from katbyte September 15, 2022 05:00

katbyte requested changes Sep 24, 2022

View reviewed changes

github-actions bot added the waiting-response label Sep 24, 2022

github-actions bot removed the waiting-response label Oct 9, 2022

modify docs

81545cc

jiaweitao001 requested a review from katbyte October 9, 2022 03:21

katbyte approved these changes Oct 12, 2022

View reviewed changes

katbyte merged commit eb6ced5 into hashicorp:main Oct 12, 2022

katbyte added a commit that referenced this pull request Oct 12, 2022

CHANGELOG #18317

1420350

github-actions bot added this to the v3.27.0 milestone Oct 12, 2022

jiaweitao001 deleted the orbital_contact branch October 13, 2022 02:49

github-actions bot locked as resolved and limited conversation to collaborators Nov 13, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

New resource: `azurerm_orbital_contact_profile` #18317

New resource: `azurerm_orbital_contact_profile` #18317

jiaweitao001 commented Sep 9, 2022

katbyte Sep 9, 2022

katbyte Sep 9, 2022

jiaweitao001 Sep 9, 2022

katbyte left a comment

katbyte Sep 13, 2022

jiaweitao001 Sep 14, 2022

katbyte Sep 24, 2022

jiaweitao001 commented Sep 15, 2022

katbyte Sep 24, 2022

katbyte Sep 24, 2022

jiaweitao001 Oct 9, 2022

katbyte left a comment

github-actions bot commented Oct 14, 2022

github-actions bot commented Nov 13, 2022

		* `modulation_configuration` - (Optional) Copy of the modem configuration file such as Kratos QRadio. Only valid for uplink directions. If provided, the modem connects to the customer endpoint and accepts commands from the customer instead of a VITA.49 stream.

		* `demodulation_configuration` - (Optional) Copy of the modem configuration file such as Kratos QRadio or Kratos QuantumRx. Only valid for downlink directions. If provided, the modem connects to the customer endpoint and sends demodulated data instead of a VITA.49 stream.

		"location": azure.SchemaLocation(),

		"links": ContactProfileLinkSchema(),

		demodulation_configuration = "na"
		modulation_configuration = "AQUA_UPLINK_BPSK"

New resource: azurerm_orbital_contact_profile #18317

New resource: azurerm_orbital_contact_profile #18317

Conversation

jiaweitao001 commented Sep 9, 2022

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

katbyte left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jiaweitao001 commented Sep 15, 2022

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

katbyte left a comment

Choose a reason for hiding this comment

github-actions bot commented Oct 14, 2022

github-actions bot commented Nov 13, 2022

New resource: `azurerm_orbital_contact_profile` #18317

New resource: `azurerm_orbital_contact_profile` #18317