azurerm_log_analytics_linked_storage_account - fix data_source_type case sensitivity

[teowa]

Resolves #16234

Use strings.ToLower(), like in the schema below

terraform-provider-azurerm/internal/services/loganalytics/log_analytics_linked_storage_account_resource.go

Lines 40 to 54 in 99542c6

	Schema: map[string]*pluginsdk.Schema{
	"data_source_type": {
	Type: pluginsdk.TypeString,
	Required: true,
	ForceNew: true,
	ValidateFunc: validation.StringInSlice([]string{
	strings.ToLower(string(operationalinsights.CustomLogs)),
	strings.ToLower(string(operationalinsights.AzureWatson)),
	strings.ToLower(string(operationalinsights.Query)),
	strings.ToLower(string(operationalinsights.Alerts)),
	// Value removed from enum in 2020-08-01, but effectively still works
	"ingestion",
	}, false),
	},

Test Result

make acctests SERVICE='loganalytics' TESTARGS='-run=TestAcclogAnalyticsLinkedStorageAccount_' TESTTIMEOUT='60m'
==> Checking that code complies with gofmt requirements...
==> Checking that Custom Timeouts are used...
==> Checking that acceptance test packages are used...
TF_ACC=1 go test -v ./internal/services/loganalytics -run=TestAcclogAnalyticsLinkedStorageAccount_ -timeout 60m -ldflags="-X=github.com/hashicorp/terraform-provider-azurerm/version.ProviderVersion=acc"
=== RUN   TestAcclogAnalyticsLinkedStorageAccount_basic
=== PAUSE TestAcclogAnalyticsLinkedStorageAccount_basic
=== RUN   TestAcclogAnalyticsLinkedStorageAccount_requiresImport
=== PAUSE TestAcclogAnalyticsLinkedStorageAccount_requiresImport
=== RUN   TestAcclogAnalyticsLinkedStorageAccount_complete
=== PAUSE TestAcclogAnalyticsLinkedStorageAccount_complete
=== RUN   TestAcclogAnalyticsLinkedStorageAccount_update
=== PAUSE TestAcclogAnalyticsLinkedStorageAccount_update
=== RUN   TestAcclogAnalyticsLinkedStorageAccount_ingestion
=== PAUSE TestAcclogAnalyticsLinkedStorageAccount_ingestion
=== CONT  TestAcclogAnalyticsLinkedStorageAccount_basic
=== CONT  TestAcclogAnalyticsLinkedStorageAccount_update
=== CONT  TestAcclogAnalyticsLinkedStorageAccount_ingestion
=== CONT  TestAcclogAnalyticsLinkedStorageAccount_complete
=== CONT  TestAcclogAnalyticsLinkedStorageAccount_requiresImport
--- PASS: TestAcclogAnalyticsLinkedStorageAccount_basic (238.75s)
--- PASS: TestAcclogAnalyticsLinkedStorageAccount_ingestion (243.31s)
--- PASS: TestAcclogAnalyticsLinkedStorageAccount_complete (246.39s)
--- PASS: TestAcclogAnalyticsLinkedStorageAccount_requiresImport (263.46s)
--- PASS: TestAcclogAnalyticsLinkedStorageAccount_update (434.67s)
PASS
ok      github.com/hashicorp/terraform-provider-azurerm/internal/services/loganalytics  434.698s

[katbyte]

LGTM ♻️ is this supposed to still be a drafT?

[teowa]

LGTM ♻️ is this supposed to still be a drafT?

This is really a special case, a Enum is used in request path to create:

terraform-provider-azurerm/internal/services/loganalytics/log_analytics_linked_storage_account_resource.go

Lines 85 to 107 in c7e7b2b

	id := linkedstorageaccounts.NewDataSourceTypeID(workspace.SubscriptionId, d.Get("resource_group_name").(string), workspace.WorkspaceName, linkedstorageaccounts.DataSourceType(d.Get("data_source_type").(string)))
	if d.IsNewResource() {
	existing, err := client.Get(ctx, id)
	if err != nil {
	if !response.WasNotFound(existing.HttpResponse) {
	return fmt.Errorf("checking for presence of existing %s: %+v", id, err)
	}
	}
	if !response.WasNotFound(existing.HttpResponse) {
	return tf.ImportAsExistsError("azurerm_log_analytics_linked_storage_account", id.ID())
	}
	}
	parameters := linkedstorageaccounts.LinkedStorageAccountsResource{
	Properties: linkedstorageaccounts.LinkedStorageAccountsProperties{
	StorageAccountIds: utils.ExpandStringSlice(d.Get("storage_account_ids").(*pluginsdk.Set).List()),
	},
	}
	if _, err := client.CreateOrUpdate(ctx, id, parameters); err != nil {
	return fmt.Errorf("creating/updating %s: %+v", id, err)
	}

I think in Read we should also set data_source_type using id.DataSourceType instead of using resp.Model.Properties.DataSourceType , align with what did in Create. Another question is the id.DataSourceType is always the Camel Case because SDK parse it (see source code), so the case diff suppression is added to schema of 3.x versions (since we ignore Enum case in 3.x).

below is a example response (id in response matches the request case, but DataSourceType in response.properties does not):

PUT https://management.azure.com/subscriptions/{{subscriptionId}}/resourceGroups/wt-test-app_ins/providers/Microsoft.OperationalInsights/workspaces/exampleworkspace/linkedStorageAccounts/CustomLogs?api-version=2020-08-01
{
    "properties": {
        "storageAccountIds": [
            "/subscriptions/{{subscriptionId}}/resourceGroups/wt-test-app_ins/providers/Microsoft.Storage/storageAccounts/wantatexamplesa"
        ]
    }
}

response:
{
    "properties": {
        "dataSourceType": "customlogs",
        "storageAccountIds": [
            "/subscriptions/{{subscriptionId}}/resourceGroups/wt-test-app_ins/providers/Microsoft.Storage/storageAccounts/wantatexamplesa"
        ]
    },
    "id": "/subscriptions/{{subscriptionId}}/resourceGroups/wt-test-app_ins/providers/Microsoft.OperationalInsights/workspaces/exampleworkspace/linkedStorageAccounts/CustomLogs",
    "name": "customlogs",
    "type": "Microsoft.OperationalInsights/workspaces/linkedStorageAccounts"
}

[teowa]

[katbyte]

@teowa - yes we should use the correct casing always

[katbyte]

this shouldn't be required because we're ignoring case till 4.0?

[katbyte]

since this is part of the id, we might want to do a state migration so we can remove the parse insensitively above?

[katbyte]

Thanks @teowa - LGTM now 🍄

[teowa]

Sorry @katbyte , it's my fault, I forget to add the StateUpgraders in resource schema, I have submitted another PR #18556 to amend this.

[github-actions]

This functionality has been released in v3.25.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.