New Resource: `azurerm_orbital_spacecraft` #17860

jiaweitao001 · 2022-08-03T07:33:18Z

All tests passed.

=== RUN   TestAccSpacecraft_basic
=== PAUSE TestAccSpacecraft_basic
=== RUN   TestAccSpacecraft_update
=== PAUSE TestAccSpacecraft_update
=== RUN   TestAccSpacecraft_complete
=== PAUSE TestAccSpacecraft_complete
=== CONT  TestAccSpacecraft_basic
=== CONT  TestAccSpacecraft_complete
=== CONT  TestAccSpacecraft_update
--- PASS: TestAccSpacecraft_basic (224.78s)
--- PASS: TestAccSpacecraft_complete (226.36s)
--- PASS: TestAccSpacecraft_update (314.83s)
PASS
ok      github.com/hashicorp/terraform-provider-azurerm/internal/services/orbital       331.335s

katbyte · 2022-08-03T23:00:11Z

internal/services/orbital/spacecraft_resource_test.go

+  norad_id            = "12345"
+  links {


tests should be formatted to be readable:

Suggested change

norad_id = "12345"

links {

norad_id = "12345"

links {

Will reformat.

katbyte · 2022-08-03T23:00:20Z

internal/services/orbital/spacecraft_resource_test.go

+  }
+  tle_line_1 = "1 23455U 94089A   97320.90946019  .00000140  00000-0  10191-3 0  2621"
+  tle_line_2 = "2 23455  99.0090 272.6745 0008546 223.1686 136.8816 14.11711747148495"
+  title_line = "AQUA"
+  tags = {


Suggested change

}

tle_line_1 = "1 23455U 94089A 97320.90946019 .00000140 00000-0 10191-3 0 2621"

tle_line_2 = "2 23455 99.0090 272.6745 0008546 223.1686 136.8816 14.11711747148495"

title_line = "AQUA"

tags = {

}

tle_line_1 = "1 23455U 94089A 97320.90946019 .00000140 00000-0 10191-3 0 2621"

tle_line_2 = "2 23455 99.0090 272.6745 0008546 223.1686 136.8816 14.11711747148495"

title_line = "AQUA"

tags = {

Will reformat.

katbyte · 2022-08-03T23:00:35Z

website/docs/r/spacecraft.html.markdown

+  norad_id            = "12345"
+  links {
+    bandwidth_mhz        = 100
+    center_frequency_mhz = 101
+    direction            = "Uplink"
+    polarization         = "LHCP"
+    name                 = "examplename"
+  }
+  tle_line_1 = "1 23455U 94089A   97320.90946019  .00000140  00000-0  10191-3 0  2621"
+  tle_line_2 = "2 23455  99.0090 272.6745 0008546 223.1686 136.8816 14.11711747148495"
+  title_line = "AQUA"
+  tags = {


and same for the docs example

Will reformat.

katbyte · 2022-08-03T23:02:33Z

website/docs/r/spacecraft.html.markdown

+  tle_line_1 = "1 23455U 94089A   97320.90946019  .00000140  00000-0  10191-3 0  2621"
+  tle_line_2 = "2 23455  99.0090 272.6745 0008546 223.1686 136.8816 14.11711747148495"


should we just make this a ordered list?

Suggested change

tle_line_1 = "1 23455U 94089A 97320.90946019 .00000140 00000-0 10191-3 0 2621"

tle_line_2 = "2 23455 99.0090 272.6745 0008546 223.1686 136.8816 14.11711747148495"

tle[0] = "1 23455U 94089A 97320.90946019 .00000140 00000-0 10191-3 0 2621"

tle[1] = "2 23455 99.0090 272.6745 0008546 223.1686 136.8816 14.11711747148495"

These 2 fields are parameters of a spacecraft's orbit, and there will be only 2 lines, the combination of them can point to a certain spacecraft. Making them a list could confuse the user a little bit.

I still don't think theres a a reason to not make this a type list? as it would be more versatile and allow users to n pass-around an array vs 2 separate strings? min items x, max items 2

i don't think it would be confusing, espically maybe if we rename it to

Suggested change

tle_line_1 = "1 23455U 94089A 97320.90946019 .00000140 00000-0 10191-3 0 2621"

tle_line_2 = "2 23455 99.0090 272.6745 0008546 223.1686 136.8816 14.11711747148495"

two_line_elements[0] = "1 23455U 94089A 97320.90946019 .00000140 00000-0 10191-3 0 2621"

two_line_elements[0] = "2 23455 99.0090 272.6745 0008546 223.1686 136.8816 14.11711747148495"

katbyte · 2022-08-03T23:03:39Z

website/docs/r/spacecraft.html.markdown

+
+---
+
+* `tle_line_1` - (Optional) The name of the field in output events used to specify the primary key which insert or update operations are based on.


line 2 is missing here

how does TLE == name of the field in output events used to specify the primary key which insert or update operations are based on. could we expand on this and make it mroe clear how these are supposed to be set?

Thanks for pointing out. This description is not accurate, will change.

katbyte · 2022-08-30T03:08:29Z

website/docs/r/spacecraft.html.markdown

+  tle_line_1 = "1 23455U 94089A   97320.90946019  .00000140  00000-0  10191-3 0  2621"
+  tle_line_2 = "2 23455  99.0090 272.6745 0008546 223.1686 136.8816 14.11711747148495"


I still don't think theres a a reason to not make this a type list? as it would be more versatile and allow users to n pass-around an array vs 2 separate strings? min items x, max items 2

i don't think it would be confusing, espically maybe if we rename it to

Suggested change

tle_line_1 = "1 23455U 94089A 97320.90946019 .00000140 00000-0 10191-3 0 2621"

tle_line_2 = "2 23455 99.0090 272.6745 0008546 223.1686 136.8816 14.11711747148495"

two_line_elements[0] = "1 23455U 94089A 97320.90946019 .00000140 00000-0 10191-3 0 2621"

two_line_elements[0] = "2 23455 99.0090 272.6745 0008546 223.1686 136.8816 14.11711747148495"

jiaweitao001 · 2022-08-30T06:42:02Z

Hi @katbyte , changed as suggested. Thanks!

katbyte · 2022-09-02T02:03:54Z

internal/services/orbital/spacecraft_resource.go

+}
+
+func (r SpacecraftResource) ResourceType() string {
+	return "azurerm_spacecraft"


what other resources will be part of this new service? should we call this resource:

Suggested change

return "azurerm_spacecraft"

return "azurerm_orbital_spacecraft"

Will update.

katbyte

Thanks @jiaweitao001 - LGTM 👾

github-actions · 2022-09-09T03:17:15Z

This functionality has been released in v3.22.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

github-actions · 2022-10-10T02:42:07Z

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

github-actions bot added dependencies documentation size/XL labels Aug 3, 2022

jiaweitao001 force-pushed the orbital_spacecraft branch 3 times, most recently from 3613616 to 2bafc11 Compare August 3, 2022 09:04

katbyte requested changes Aug 3, 2022

View reviewed changes

jiaweitao001 force-pushed the orbital_spacecraft branch from d0e6d02 to 38dfeca Compare August 4, 2022 03:22

github-actions bot added the service/postgresql label Aug 4, 2022

jiaweitao001 force-pushed the orbital_spacecraft branch from 38dfeca to 5a98052 Compare August 4, 2022 04:17

github-actions bot removed the service/postgresql label Aug 4, 2022

jiaweitao001 requested a review from katbyte August 4, 2022 06:51

jiaweitao001 force-pushed the orbital_spacecraft branch from b800141 to b8a13ec Compare August 17, 2022 07:57

katbyte requested changes Aug 30, 2022

View reviewed changes

jiaweitao001 force-pushed the orbital_spacecraft branch 3 times, most recently from 32790ae to 132ee95 Compare August 30, 2022 06:03

jiaweitao001 requested a review from katbyte August 30, 2022 06:42

jiaweitao001 force-pushed the orbital_spacecraft branch 2 times, most recently from af5ad8a to 6e5faaa Compare September 1, 2022 02:02

jiaweitao001 changed the title ~~New Resource: azurerm_spacecraft in orbital service~~ New Resource: azurerm_spacecraft Sep 1, 2022

katbyte requested changes Sep 4, 2022

View reviewed changes

github-actions bot added the waiting-response label Sep 4, 2022

jiaweitao001 added 5 commits September 5, 2022 15:39

New Resource: in orbital service

4f5e43f

Fix weblint

3a74c83

Fixing gencheck

e963024

adding Orbital subcategory

d639b13

Add website category

3598d57

jiaweitao001 added 3 commits September 5, 2022 15:39

update dependencies

acb02a3

Reformat tle lines

920f781

fix dependency check

8604f00

github-actions bot removed the waiting-response label Sep 5, 2022

rename resource

ce9674f

jiaweitao001 force-pushed the orbital_spacecraft branch from 6e5faaa to ce9674f Compare September 5, 2022 08:35

jiaweitao001 requested a review from katbyte September 5, 2022 08:37

katbyte approved these changes Sep 6, 2022

View reviewed changes

katbyte merged commit a503f9f into hashicorp:main Sep 6, 2022

github-actions bot added this to the v3.22.0 milestone Sep 6, 2022

katbyte changed the title ~~New Resource: azurerm_spacecraft~~ New Resource: azurerm_orbital_spacecraft Sep 6, 2022

katbyte added a commit that referenced this pull request Sep 6, 2022

CHANGELOG #17860

f679aaa

github-actions bot locked as resolved and limited conversation to collaborators Oct 10, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

New Resource: `azurerm_orbital_spacecraft` #17860

New Resource: `azurerm_orbital_spacecraft` #17860

jiaweitao001 commented Aug 3, 2022

katbyte Aug 3, 2022

jiaweitao001 Aug 4, 2022

katbyte Aug 3, 2022

jiaweitao001 Aug 4, 2022

katbyte Aug 3, 2022

jiaweitao001 Aug 4, 2022

katbyte Aug 3, 2022

jiaweitao001 Aug 4, 2022

katbyte Aug 30, 2022

katbyte Aug 3, 2022

jiaweitao001 Aug 4, 2022

katbyte Aug 30, 2022

jiaweitao001 commented Aug 30, 2022

katbyte Sep 2, 2022

jiaweitao001 Sep 5, 2022

katbyte left a comment

github-actions bot commented Sep 9, 2022

github-actions bot commented Oct 10, 2022

		tle_line_1 = "1 23455U 94089A 97320.90946019 .00000140 00000-0 10191-3 0 2621"
		tle_line_2 = "2 23455 99.0090 272.6745 0008546 223.1686 136.8816 14.11711747148495"


		---

		* `tle_line_1` - (Optional) The name of the field in output events used to specify the primary key which insert or update operations are based on.

	return "azurerm_spacecraft"
	return "azurerm_orbital_spacecraft"

New Resource: azurerm_orbital_spacecraft #17860

New Resource: azurerm_orbital_spacecraft #17860

Conversation

jiaweitao001 commented Aug 3, 2022

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jiaweitao001 commented Aug 30, 2022

Choose a reason for hiding this comment

Choose a reason for hiding this comment

katbyte left a comment

Choose a reason for hiding this comment

github-actions bot commented Sep 9, 2022

github-actions bot commented Oct 10, 2022

New Resource: `azurerm_orbital_spacecraft` #17860

New Resource: `azurerm_orbital_spacecraft` #17860