azurerm_api_management_api Deprecate soap_pass_through in favour of api_type

[owenfarrell]

Community Note

• Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Summary

This pull request converts a boolean flag for SOAP support in to an enumeration that supports SOAP, GraphQL, and websockets.

Fixes: #16452
Fixes: #14634

Output from acceptance testing:

make acctests SERVICE='apimanagement' TESTARGS='-run="TestAccApiManagementApi_"'
==> Checking that code complies with gofmt requirements...
==> Checking that Custom Timeouts are used...
==> Checking that acceptance test packages are used...
TF_ACC=1 go test -v ./internal/services/apimanagement -run="TestAccApiManagementApi_" -timeout 180m -ldflags="-X=github.com/hashicorp/terraform-provider-azurerm/version.ProviderVersion=acc"
=== RUN   TestAccApiManagementApi_basic
=== PAUSE TestAccApiManagementApi_basic
=== RUN   TestAccApiManagementApi_wordRevision
=== PAUSE TestAccApiManagementApi_wordRevision
=== RUN   TestAccApiManagementApi_blankPath
=== PAUSE TestAccApiManagementApi_blankPath
=== RUN   TestAccApiManagementApi_version
=== PAUSE TestAccApiManagementApi_version
=== RUN   TestAccApiManagementApi_oauth2Authorization
=== PAUSE TestAccApiManagementApi_oauth2Authorization
=== RUN   TestAccApiManagementApi_openidAuthentication
=== PAUSE TestAccApiManagementApi_openidAuthentication
=== RUN   TestAccApiManagementApi_requiresImport
=== PAUSE TestAccApiManagementApi_requiresImport
=== RUN   TestAccApiManagementApi_graphql
=== PAUSE TestAccApiManagementApi_graphql
=== RUN   TestAccApiManagementApi_soap
=== PAUSE TestAccApiManagementApi_soap
=== RUN   TestAccApiManagementApi_websocket
=== PAUSE TestAccApiManagementApi_websocket
=== RUN   TestAccApiManagementApi_soapPassthrough
=== PAUSE TestAccApiManagementApi_soapPassthrough
=== RUN   TestAccApiManagementApi_subscriptionRequired
=== PAUSE TestAccApiManagementApi_subscriptionRequired
=== RUN   TestAccApiManagementApi_importSwagger
=== PAUSE TestAccApiManagementApi_importSwagger
=== RUN   TestAccApiManagementApi_importWsdl
=== PAUSE TestAccApiManagementApi_importWsdl
=== RUN   TestAccApiManagementApi_importUpdate
=== PAUSE TestAccApiManagementApi_importUpdate
=== RUN   TestAccApiManagementApi_complete
=== PAUSE TestAccApiManagementApi_complete
=== RUN   TestAccApiManagementApi_cloneApi
=== PAUSE TestAccApiManagementApi_cloneApi
=== RUN   TestAccApiManagementApi_createNewVersionFromExisting
=== PAUSE TestAccApiManagementApi_createNewVersionFromExisting
=== RUN   TestAccApiManagementApi_createRevisionFromExisting
=== PAUSE TestAccApiManagementApi_createRevisionFromExisting
=== RUN   TestAccApiManagementApi_createRevisionFromExistingRevision
=== PAUSE TestAccApiManagementApi_createRevisionFromExistingRevision
=== CONT  TestAccApiManagementApi_basic
=== CONT  TestAccApiManagementApi_soapPassthrough
=== CONT  TestAccApiManagementApi_createRevisionFromExistingRevision
=== CONT  TestAccApiManagementApi_createRevisionFromExisting
=== CONT  TestAccApiManagementApi_importSwagger
=== CONT  TestAccApiManagementApi_subscriptionRequired
=== CONT  TestAccApiManagementApi_importUpdate
=== CONT  TestAccApiManagementApi_createNewVersionFromExisting
--- PASS: TestAccApiManagementApi_createRevisionFromExistingRevision (482.91s)
=== CONT  TestAccApiManagementApi_cloneApi
--- PASS: TestAccApiManagementApi_basic (485.29s)
=== CONT  TestAccApiManagementApi_complete
--- PASS: TestAccApiManagementApi_createRevisionFromExisting (486.22s)
=== CONT  TestAccApiManagementApi_openidAuthentication
--- PASS: TestAccApiManagementApi_subscriptionRequired (536.88s)
=== CONT  TestAccApiManagementApi_websocket
--- PASS: TestAccApiManagementApi_importSwagger (538.44s)
=== CONT  TestAccApiManagementApi_soap
--- PASS: TestAccApiManagementApi_soapPassthrough (542.24s)
=== CONT  TestAccApiManagementApi_graphql
--- PASS: TestAccApiManagementApi_createNewVersionFromExisting (546.80s)
=== CONT  TestAccApiManagementApi_requiresImport
--- PASS: TestAccApiManagementApi_importUpdate (599.75s)
=== CONT  TestAccApiManagementApi_blankPath
--- PASS: TestAccApiManagementApi_complete (476.38s)
=== CONT  TestAccApiManagementApi_oauth2Authorization
--- PASS: TestAccApiManagementApi_openidAuthentication (481.39s)
=== CONT  TestAccApiManagementApi_version
--- PASS: TestAccApiManagementApi_requiresImport (420.99s)
=== CONT  TestAccApiManagementApi_wordRevision
--- PASS: TestAccApiManagementApi_soap (467.23s)
=== CONT  TestAccApiManagementApi_importWsdl
--- PASS: TestAccApiManagementApi_graphql (471.47s)
--- PASS: TestAccApiManagementApi_blankPath (470.15s)
--- PASS: TestAccApiManagementApi_cloneApi (678.76s)
--- PASS: TestAccApiManagementApi_version (405.41s)
--- PASS: TestAccApiManagementApi_oauth2Authorization (458.98s)
--- PASS: TestAccApiManagementApi_wordRevision (465.45s)
--- PASS: TestAccApiManagementApi_importWsdl (467.09s)
--- PASS: TestAccApiManagementApi_websocket (4857.74s)
PASS
ok      github.com/hashicorp/terraform-provider-azurerm/internal/services/apimanagement 5397.663s

[katbyte]

Thanks @owenfarrell - LGTM ♻️

[github-actions]

This functionality has been released in v3.22.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.