domainservice: refactoring domainservice resources to using go-azure-sdk #17595
Conversation
| return fmt.Errorf("reading Domain Service: ID was returned nil") | ||
| } | ||
| d.SetId(*resp.ID) | ||
| d.SetId(*model.Id) |
There was a problem hiding this comment.
is there a reason we're using this ID rather than the Resource ID above? they aren't guaranteed to be the same casing-wise?
There was a problem hiding this comment.
@tombuildsstuff I also noticed this, whilst I don't know whether changing this to the resource ID will introduce a breaking change. The intent of this PR is to switch the SDK verbatim.
There was a problem hiding this comment.
We should move also move towards using our generated IDs over the model ids in this swap too. Let's check to see if the ids are different too. If they are, we need to write a migration on top of it
There was a problem hiding this comment.
@mbfrahry I've made the change.
|
This functionality has been released in v3.15.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions. |
Refactoring domainservice resources to using go-azure-sdk.