change sku tier to not force new

[diklatze]

We have added a feature for single-click migration that upgrade the SKU and there is no need to force new.

[katbyte]

Thanks @diklatze - could we update the "update" test to ensure its changing the sku to verify this works (and continues to do so)

[diklatze]

Thanks @diklatze - could we update the "update" test to ensure its changing the sku to verify this works (and continues to do so)

@katbyte I have added a test. Is that what you mean?

[bewatersmsft]

@katbyte we're trying to release this feature (we're from the Azure Firewall team) and need this approved so we can have our terraform customers not delete their existing firewalls on upgrade

[katbyte]

@diklatze - running tests for this and i am getting a failure:

you'll also need to update the docs, once thats all fixed up we can get this merged

[stephybun]

Thanks for this @diklatze, the test was still failing with the same error as before, I hope you don't mind I went ahead and pushed a fix for it so that we can get this in to the next release.
On that note, LGTM 👍

[github-actions]

This functionality has been released in v3.17.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.