Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azurerm_kusto_cluster - Add new public_ip_address property #17520

Merged

Conversation

liuwuliuyun
Copy link
Contributor

Update 'public_ip_address' property to resource kusto cluster.

@liuwuliuyun
Copy link
Contributor Author

Testing evidence will be provided shortly.

@liuwuliuyun
Copy link
Contributor Author

Test on TestAccKustoCluster_update locally, result is as follows:

GOROOT=D:\Program Files\Go #gosetup
GOPATH=C:\Users\yunliu1\go #gosetup
"D:\Program Files\Go\bin\go.exe" test -c -o C:\Users\yunliu1\AppData\Local\Temp\GoLand___TestAccKustoCluster_update_in_github_com_hashicorp_terraform_provider_azurerm_internal_services_kusto.test.exe github.com/hashicorp/terraform-provider-azurerm/internal/services/kusto #gosetup
"D:\Program Files\Go\bin\go.exe" tool test2json -t C:\Users\yunliu1\AppData\Local\Temp\GoLand___TestAccKustoCluster_update_in_github_com_hashicorp_terraform_provider_azurerm_internal_services_kusto.test.exe -test.v -test.paniconexit0 -test.run ^\QTestAccKustoCluster_update\E$ #gosetup
=== RUN TestAccKustoCluster_update
=== PAUSE TestAccKustoCluster_update
=== CONT TestAccKustoCluster_update
--- PASS: TestAccKustoCluster_update (4279.44s)
PASS

Process finished with the exit code 0

@liuwuliuyun liuwuliuyun changed the title Update 'public_ip_address' property to resource kusto cluster Add new 'public_ip_address' property to resource kusto cluster Jul 6, 2022
@liuwuliuyun
Copy link
Contributor Author

TestAccKustoCluster_complete results:

========================== Starting Command Output ===========================
##[debug]which '/usr/bin/bash'
##[debug]found: '/usr/bin/bash'
##[debug]/usr/bin/bash arg: /home/vsts/work/_temp/264e6dcd-23f8-49dc-8942-6b719799d2f0.sh
##[debug]exec tool: /usr/bin/bash
##[debug]arguments:
##[debug] /home/vsts/work/_temp/264e6dcd-23f8-49dc-8942-6b719799d2f0.sh
/usr/bin/bash /home/vsts/work/_temp/264e6dcd-23f8-49dc-8942-6b719799d2f0.sh
=== RUN TestAccKustoCluster_complete
=== PAUSE TestAccKustoCluster_complete
=== CONT TestAccKustoCluster_complete
--- PASS: TestAccKustoCluster_complete (1182.22s)
PASS
ok github.com/hashicorp/terraform-provider-azurerm/internal/services/kusto 1182.237s
##[debug]Exit code 0 received from tool '/usr/bin/bash'
##[debug]STDIO streams have closed for tool '/usr/bin/bash'
##[debug]task result: Succeeded
##[debug]Processed: ##vso[task.complete result=Succeeded;done=true;]
Finishing: Run test in parallel

@liuwuliuyun liuwuliuyun changed the title Add new 'public_ip_address' property to resource kusto cluster Add new public_ip_address property to resource kusto cluster Jul 7, 2022
Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎩

@katbyte katbyte changed the title Add new public_ip_address property to resource kusto cluster azurerm_kusto_cluster - Add new public_ip_address property Jul 8, 2022
@katbyte katbyte merged commit 6bbd6c1 into hashicorp:main Jul 8, 2022
katbyte added a commit that referenced this pull request Jul 8, 2022
@github-actions github-actions bot added this to the v3.14.0 milestone Jul 8, 2022
@github-actions
Copy link

This functionality has been released in v3.14.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 15, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants