-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New resources gallery_application
gallery_application_version
#17394
Conversation
myc2h6o
commented
Jun 27, 2022
•
edited
Loading
edited
- Adding support for Gallery Application. It is similar to Shared Image in Shared Image Gallery (Azure Compute Gallery), which can be configured for a VM/VMSS.
- Doc: https://docs.microsoft.com/en-us/azure/virtual-machines/vm-applications
- Swagger:
- Gallery Application
- Gallery Application Version
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
test failure:
------- Stdout: -------
=== RUN TestAccGalleryApplicationVersion_targetRegion
=== PAUSE TestAccGalleryApplicationVersion_targetRegion
=== CONT TestAccGalleryApplicationVersion_targetRegion
testing_new.go:70: Error running post-test destroy, there may be dangling resources: exit status 1
Error: deleting Gallery Application: (Application Name "acctest-app-220627192519280007" / Gallery Name "acctestsig220627192519280007" / Resource Group "acctest-compute-220627192519280007"): compute.GalleryApplicationsClient#Delete: Failure sending request: StatusCode=0 -- Original Error: autorest/azure: Service returned an error. Status=<nil> Code="CannotDeleteResource" Message="Can not delete resource before nested resources are deleted."
deleting Gallery Application: (Application Name
"acctest-app-220627192519280007" / Gallery Name
"acctestsig220627192519280007" / Resource Group
"acctest-compute-220627192519280007"):
compute.GalleryApplicationsClient#Delete: Failure sending request:
StatusCode=0 -- Original Error: autorest/azure: Service returned an error.
Status=<nil> Code="CannotDeleteResource" Message="Can not delete resource
before nested resources are deleted."
--- FAIL: TestAccGalleryApplicationVersion_targetRegion (1181.51s)
FAIL
- the delete might be happening to soon/something might need to wait
Hi @katbyte thanks for reviewing the pr and catching the issue. We do have to add a wait to the Application Version here. I've added the state refresh similar to what we did for Shared Image Version here, and opened an issue Azure/azure-rest-api-specs#19686 to track it. Could you take another look? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @myc2h6o - LGTM 🌤️
This functionality has been released in v3.14.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions. |