Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vmware: refactoring to use go-azure-sdk #17381

Merged
merged 2 commits into from
Jun 27, 2022
Merged

vmware: refactoring to use go-azure-sdk #17381

merged 2 commits into from
Jun 27, 2022

Conversation

tombuildsstuff
Copy link
Contributor

This PR refactors the vmware package from using an Embedded SDK to using hashicorp/go-azure-sdk

@tombuildsstuff tombuildsstuff added this to the v3.12.0 milestone Jun 25, 2022
@tombuildsstuff tombuildsstuff requested a review from a team June 25, 2022 04:46
stephybun
stephybun approved these changes Jun 26, 2022
View reviewed changes
Copy link
Member

@stephybun stephybun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🍌

@tombuildsstuff tombuildsstuff force-pushed the r/vmware-to-go-azure-sdk branch from 35d79a3 to 8e9809b Compare June 27, 2022 06:54
@tombuildsstuff
Copy link
Contributor Author

There's a few of these to rebase and the only difference was a vendor file merge conflict - this is safe to merge 👍

@tombuildsstuff tombuildsstuff merged commit a715744 into main Jun 27, 2022
@tombuildsstuff tombuildsstuff deleted the r/vmware-to-go-azure-sdk branch June 27, 2022 07:06
tombuildsstuff added a commit that referenced this pull request Jun 27, 2022
@tombuildsstuff
updating to include #17381
583c64b
@github-actions
Copy link

github-actions bot commented Jul 1, 2022

This functionality has been released in v3.12.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

sergelogvinov pushed a commit to sergelogvinov/terraform-provider-azurerm that referenced this pull request Jul 11, 2022
@tombuildsstuff @sergelogvinov
updating to include hashicorp#17381
6939dca
@github-actions
Copy link

github-actions bot commented Aug 1, 2022

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 1, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@stephybun stephybun stephybun approved these changes

Assignees
No one assigned
Labels
dependencies refactor service/vmware size/XL
Projects
None yet
Milestone
v3.12.0
Development

Successfully merging this pull request may close these issues.
2 participants
@tombuildsstuff @stephybun