Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New Resource - azurerm_fluid_relay_server #17238

Merged
merged 32 commits into from
Jul 7, 2022
Merged

New Resource - azurerm_fluid_relay_server #17238

merged 32 commits into from
Jul 7, 2022

Conversation

wuxu92
Copy link
Contributor

@wuxu92 wuxu92 commented Jun 14, 2022 •
edited
Loading

Swagger Link

--- PASS: TestAccFluidRelay_basic (55.64s)
--- PASS: TestAccFluidRelay_ami (420.68s)
--- PASS: TestAccFluidRelayServer_requiresImport (64.67s)
--- PASS: TestAccFluidRelayServer_update (248.55s)

Process finished with the exit code 0

magodo
magodo requested changes Jun 14, 2022
View reviewed changes
Copy link
Collaborator

@magodo magodo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this PR!
I've taken a look through and left some comments inline, but this is mostly looking good to me 👍

internal/services/fluidrelay/validate/server_name.go Show resolved Hide resolved
website/docs/r/mssql_server_dns_alias.html.markdown Outdated Show resolved Hide resolved
website/docs/r/fluid_relay_servers.html.markdown Outdated Show resolved Hide resolved
website/docs/r/fluid_relay_servers.html.markdown Outdated Show resolved Hide resolved
website/docs/r/fluid_relay_servers.html.markdown Outdated Show resolved Hide resolved
internal/services/fluidrelay/fluid_relay_servers_resource.go Outdated Show resolved Hide resolved
internal/services/fluidrelay/fluid_relay_servers_resource.go Outdated Show resolved Hide resolved
internal/services/fluidrelay/fluid_relay_servers_resource.go Outdated Show resolved Hide resolved
internal/services/fluidrelay/fluid_relay_servers_resource.go Outdated Show resolved Hide resolved
internal/services/fluidrelay/fluid_relay_servers_resource.go Outdated Show resolved Hide resolved
magodo
magodo requested changes Jun 16, 2022
View reviewed changes
Copy link
Collaborator

@magodo magodo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have left some additional comments that once addressed this should be good to merge 👍

internal/services/fluidrelay/fluid_relay_servers_resource.go Outdated Show resolved Hide resolved
internal/services/fluidrelay/fluid_relay_servers_resource.go Outdated Show resolved Hide resolved
internal/services/fluidrelay/fluid_relay_servers_resource.go Outdated Show resolved Hide resolved
internal/services/fluidrelay/fluid_relay_servers_resource.go Outdated Show resolved Hide resolved
internal/services/fluidrelay/fluid_relay_servers_resource.go Outdated Show resolved Hide resolved
website/docs/r/fluid_relay_servers.html.markdown Outdated Show resolved Hide resolved
website/docs/r/fluid_relay_servers.html.markdown Outdated Show resolved Hide resolved
website/docs/r/fluid_relay_servers.html.markdown Outdated Show resolved Hide resolved
website/docs/r/fluid_relay_servers.html.markdown Outdated Show resolved Hide resolved
internal/services/fluidrelay/fluid_relay_servers_resource_test.go Show resolved Hide resolved
@magodo
Copy link
Collaborator

magodo commented Jun 17, 2022 •
edited
Loading

Thank you @wuxu92! This almost LGTM now! If you can fix the CI failures, then I'll trigger an acctest run.

@wuxu92
Copy link
Contributor Author

wuxu92 commented Jun 17, 2022

Thank you @wuxu92! This almost LGTM now! If you can fix the CI failures, then I'll trigger an acctest run.

thanks a lot! now all CI checks are success.

wuxu92 and others added 18 commits June 22, 2022 16:56
katbyte
katbyte requested changes Jun 27, 2022
View reviewed changes
Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @wuxu92 - left comments inline

website/docs/r/fluid_relay_servers.html.markdown Show resolved Hide resolved
website/docs/r/fluid_relay_servers.html.markdown Outdated Show resolved Hide resolved
website/docs/r/fluid_relay_servers.html.markdown Outdated Show resolved Hide resolved
website/docs/r/fluid_relay_servers.html.markdown Outdated Show resolved Hide resolved
internal/services/fluidrelay/fluid_relay_servers_resource.go Outdated Show resolved Hide resolved
website/docs/r/fluid_relay_servers.html.markdown Show resolved Hide resolved
mbfrahry
mbfrahry requested changes Jul 7, 2022
View reviewed changes
Copy link
Member

@mbfrahry mbfrahry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @wuxu92. This looks nearly there but storage_sku is a little weird. I've left comments in line but once that is addressed, I believe we can merge it

internal/services/fluidrelay/fluid_relay_servers_resource.go Show resolved Hide resolved
mbfrahry
mbfrahry approved these changes Jul 7, 2022
View reviewed changes
Copy link
Member

@mbfrahry mbfrahry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for opening that issue!

@mbfrahry mbfrahry merged commit 957f153 into hashicorp:main Jul 7, 2022
@mbfrahry mbfrahry added this to the v3.13.0 milestone Jul 7, 2022
mbfrahry added a commit that referenced this pull request Jul 7, 2022
@mbfrahry
Update changelog for #17238
798d6af
@github-actions
Copy link

github-actions bot commented Jul 8, 2022

This functionality has been released in v3.13.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

github-actions bot commented Aug 8, 2022

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 8, 2022
@wuxu92 wuxu92 deleted the t/fluidrelay branch October 14, 2022 07:11
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ahmedbisht ahmedbisht ahmedbisht left review comments

@magodo magodo magodo requested changes

@katbyte katbyte katbyte requested changes

@mbfrahry mbfrahry mbfrahry approved these changes

Assignees
No one assigned
Labels
dependencies documentation size/XL
Projects
None yet
Milestone
v3.13.0
Development

Successfully merging this pull request may close these issues.
5 participants
@wuxu92 @magodo @katbyte @mbfrahry @ahmedbisht