Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump terraform-plugin-sdk to v2.18.0 to increase the size of gRPC messages upto 256MB #17141

Merged
merged 4 commits into from
Jul 11, 2022

Conversation

harshavmb
Copy link
Contributor

@harshavmb harshavmb commented Jun 7, 2022

At the moment, the gRPC messages larger than 4MB are failing.

As documented here, I see below comments by Hashicorp team to upgrade the sdk version to increase gRPC message sizes by each provider.

The feature update to increase the size to 256MB has been implemented in terraform-plugin-go v0.6.0 and is used by the terraform-plugin-sdk. However, this update has not been adopted by the provider plugins yet.

I did bump the terraform-plugin-sdk to v2.18.0 which has this feature included. This helps azurerm provider to have the leverage of having gRPC messages larger than 4 MB.

Our use case was playing with large template files.

Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @harshavmb - LGTM and good to go once the merge conflicts have been resolved!

@harshavmb harshavmb changed the title Bump terraform-plugin-sdk to v2.11.0 to increase the size of gRPC messages upto 256MB Bump terraform-plugin-sdk to v2.18.0 to increase the size of gRPC messages upto 256MB Jul 7, 2022
@harshavmb harshavmb requested a review from katbyte July 7, 2022 11:01
@harshavmb
Copy link
Contributor Author

Thanks @harshavmb - LGTM and good to go once the merge conflicts have been resolved!

Hi @katbyte ,

I've merged conflicts. Could you please review it quickly as go.mod file is prone to have conflicts often?

Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @harshavmb - LGTM 🔝

@katbyte katbyte merged commit 60bf7a9 into hashicorp:main Jul 11, 2022
@github-actions github-actions bot added this to the v3.14.0 milestone Jul 11, 2022
katbyte added a commit that referenced this pull request Jul 11, 2022
tombuildsstuff added a commit that referenced this pull request Jul 11, 2022
@github-actions
Copy link

This functionality has been released in v3.14.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 15, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants