Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

azurerm_linux_virtual_machine_scale_set azurerm_windows_virtual_machine_scale_set: Add support for Confidential VM #16916

Merged
merged 1 commit into from
May 25, 2022
Merged

azurerm_linux_virtual_machine_scale_set azurerm_windows_virtual_machine_scale_set: Add support for Confidential VM #16916

merged 1 commit into from
May 25, 2022

Conversation

myc2h6o
Copy link
Contributor

@myc2h6o myc2h6o commented May 23, 2022

Cont. of #16905, to add Confidential VM support in VMSS. Only uniformed VMSS support this.

@myc2h6o myc2h6o force-pushed the confidential_vmss branch from 325034b to e85053d Compare May 23, 2022 13:22
@myc2h6o myc2h6o force-pushed the confidential_vmss branch from e85053d to 00c6120 Compare May 23, 2022 13:28
@myc2h6o
Copy link
Contributor Author

myc2h6o commented May 24, 2022

Test result for Linux and Windows specifically (Failed tests are non-related and fail on main as well)
image
image

@WodansSon WodansSon added this to the v3.8.0 milestone May 24, 2022
WodansSon
WodansSon approved these changes May 24, 2022
View reviewed changes
Copy link
Collaborator

@WodansSon WodansSon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@myc2h6o thank you for this PR... LGTM... 🚀

@WodansSon WodansSon changed the title r\linux_virtual_machine_scale_set r\windows_virtual_machine_scale_set: Add support for Confidential VM azurerm_linux_virtual_machine_scale_set azurerm_windows_virtual_machine_scale_set: Add support for Confidential VM May 24, 2022
@WodansSon WodansSon merged commit 666cade into hashicorp:main May 25, 2022
WodansSon added a commit that referenced this pull request May 25, 2022
@WodansSon
Updating to include #16905 #16908 and #16916
19ce02e
@myc2h6o myc2h6o deleted the confidential_vmss branch May 25, 2022 03:28
@github-actions
Copy link

This functionality has been released in v3.8.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 30, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@WodansSon WodansSon WodansSon approved these changes

Assignees
No one assigned
Labels
documentation size/XL
Projects
None yet
Milestone
v3.8.0
Development

Successfully merging this pull request may close these issues.
2 participants
@myc2h6o @WodansSon