Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New resource - azurerm_mssql_server_dns_alias #16861

Merged
merged 4 commits into from
May 26, 2022
Merged

New resource - azurerm_mssql_server_dns_alias #16861

merged 4 commits into from
May 26, 2022
+655 −0

Conversation

wuxu92
Copy link
Contributor

@wuxu92 wuxu92 commented May 19, 2022 •
edited
Loading

@magodo magodo changed the title new resource azurerm_mssql_server_dns_alias add mssql dns alias support New resource - azurerm_mssql_server_dns_alias May 19, 2022
magodo
magodo requested changes May 19, 2022
View reviewed changes
Copy link
Collaborator

@magodo magodo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this PR!
I've taken a look through and left some comments inline, but this is mostly looking good to me 👍

internal/services/mssql/mssql_server_dns_alias_resource.go Outdated Show resolved Hide resolved
internal/services/mssql/mssql_server_dns_alias_resource.go Outdated Show resolved Hide resolved
internal/services/mssql/mssql_server_dns_alias_resource.go Outdated Show resolved Hide resolved
internal/services/mssql/mssql_server_dns_alias_resource.go Outdated Show resolved Hide resolved
@wuxu92 wuxu92 force-pushed the feat_sqldnsalias branch 2 times, most recently from c9f980b to 8d13c70 Compare May 19, 2022 09:17
magodo
magodo requested changes May 19, 2022
View reviewed changes
Copy link
Collaborator

@magodo magodo left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@wuxu92 I have left some additional mostly minor comments that once addressed this should be good to merge 👍

internal/services/mssql/mssql_server_dns_alias_resource.go Outdated Show resolved Hide resolved
@wuxu92 wuxu92 force-pushed the feat_sqldnsalias branch 3 times, most recently from 804d02a to 6ceddee Compare May 20, 2022 02:47
@wuxu92 wuxu92 force-pushed the feat_sqldnsalias branch from 6ceddee to ecf18cf Compare May 20, 2022 02:53
@wuxu92 wuxu92 requested a review from magodo May 23, 2022 02:03
@WodansSon WodansSon added this to the v3.9.0 milestone May 25, 2022
katbyte
katbyte approved these changes May 26, 2022
View reviewed changes
Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🖲️

@katbyte katbyte merged commit 8422641 into hashicorp:main May 26, 2022
@katbyte katbyte modified the milestones: v3.9.0, v3.8.0 May 26, 2022
katbyte added a commit that referenced this pull request May 26, 2022
@katbyte
CHANGELOG #16861
f68fb61
@github-actions
Copy link

This functionality has been released in v3.8.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 30, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@katbyte katbyte katbyte approved these changes

@magodo magodo Awaiting requested review from magodo

Assignees
No one assigned
Labels
documentation new-resource service/mssql Microsoft SQL Server size/XL
Projects
None yet
Milestone
v3.8.0
Development

Successfully merging this pull request may close these issues.

Support for Azure SQL server DNS alias
4 participants
@wuxu92 @katbyte @magodo @WodansSon