Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azurerm_mssql_managed_instance - add support for maintenance_configuration_name #16832

Merged
merged 2 commits into from
May 18, 2022

Conversation

catriona-m
Copy link
Member

fixes #13959

Copy link
Member

@mbfrahry mbfrahry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with a minor comment about where to pull the subscription id from

internal/services/mssql/mssql_managed_instance_resource.go Outdated Show resolved Hide resolved
@catriona-m catriona-m merged commit 5d49be5 into main May 18, 2022
@catriona-m catriona-m deleted the cm/sqlmanagedmainconfig branch May 18, 2022 12:46
@github-actions github-actions bot added this to the v3.7.0 milestone May 18, 2022
catriona-m added a commit that referenced this pull request May 18, 2022
@github-actions
Copy link

This functionality has been released in v3.7.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 20, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for setting maintenance windows on azurerm_sql_managed_instance
2 participants