Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azurerm_data_factory_dataset_delimited_text Add missing default values to fix #13545 #16543

Merged
merged 1 commit into from
Apr 29, 2022

Conversation

lonegunmanb
Copy link
Contributor

This pr fix #13545 by adding the missing default values.

Acc tests:

=== RUN TestAccDataFactoryDatasetDelimitedText_http
=== PAUSE TestAccDataFactoryDatasetDelimitedText_http
=== CONT TestAccDataFactoryDatasetDelimitedText_http
--- PASS: TestAccDataFactoryDatasetDelimitedText_http (244.74s)
=== RUN TestAccDataFactoryDatasetDelimitedText_http_update
=== PAUSE TestAccDataFactoryDatasetDelimitedText_http_update
=== CONT TestAccDataFactoryDatasetDelimitedText_http_update
--- PASS: TestAccDataFactoryDatasetDelimitedText_http_update (358.27s)
=== RUN TestAccDataFactoryDatasetDelimitedText_blob_basic
=== PAUSE TestAccDataFactoryDatasetDelimitedText_blob_basic
=== CONT TestAccDataFactoryDatasetDelimitedText_blob_basic
--- PASS: TestAccDataFactoryDatasetDelimitedText_blob_basic (269.31s)
=== RUN TestAccDataFactoryDatasetDelimitedText_blob
=== PAUSE TestAccDataFactoryDatasetDelimitedText_blob
=== CONT TestAccDataFactoryDatasetDelimitedText_blob
--- PASS: TestAccDataFactoryDatasetDelimitedText_blob (259.26s)
=== RUN TestAccDataFactoryDatasetDelimitedText_blob_empty_path
=== PAUSE TestAccDataFactoryDatasetDelimitedText_blob_empty_path
=== CONT TestAccDataFactoryDatasetDelimitedText_blob_empty_path
--- PASS: TestAccDataFactoryDatasetDelimitedText_blob_empty_path (269.73s)
=== RUN TestAccDataFactoryDatasetDelimitedText_blobFS
=== PAUSE TestAccDataFactoryDatasetDelimitedText_blobFS
=== CONT TestAccDataFactoryDatasetDelimitedText_blobFS
--- PASS: TestAccDataFactoryDatasetDelimitedText_blobFS (284.44s)
=== RUN TestAccDataFactoryDatasetDelimitedText_blobDynamicContainer
=== PAUSE TestAccDataFactoryDatasetDelimitedText_blobDynamicContainer
=== CONT TestAccDataFactoryDatasetDelimitedText_blobDynamicContainer
--- PASS: TestAccDataFactoryDatasetDelimitedText_blobDynamicContainer (495.68s)
PASS

@lonegunmanb lonegunmanb changed the title Add missing default values to fix #13545 azurerm_data_factory_dataset_delimited_text Add missing default values to fix #13545 Apr 25, 2022
Copy link
Member

@stephybun stephybun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @lonegunmanb, LGTM 🥟

@stephybun stephybun merged commit 90d3eca into hashicorp:main Apr 29, 2022
@github-actions github-actions bot added this to the v3.5.0 milestone Apr 29, 2022
stephybun added a commit that referenced this pull request Apr 29, 2022
@github-actions
Copy link

github-actions bot commented May 6, 2022

This functionality has been released in v3.5.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

github-actions bot commented Jun 5, 2022

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 5, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

azurerm_data_factory_delimited_text type properties don't default correctly
2 participants