Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azurerm_postgresql_server - add validation for public_network_access_enabled #16516

Merged
merged 2 commits into from
Apr 29, 2022

Conversation

neil-yechenwei
Copy link
Contributor

@neil-yechenwei neil-yechenwei commented Apr 23, 2022

Service team confirmed API doesn't support public_network_access_enabled when create_mode is PointInTimeRestore. So it's better to add a validation for it.

--- PASS: TestAccPostgreSQLServer_threatDetectionEmptyAttrs (421.22s)
--- PASS: TestAccPostgreSQLServer_complete (428.06s)
--- PASS: TestAccPostgreSQLServer_basicNinePointFive (442.13s)
--- PASS: TestAccPostgreSQLServer_basicEleven (464.25s)
--- PASS: TestAccPostgreSQLServer_requiresImport (482.34s)
--- PASS: TestAccPostgreSQLServer_autogrowOnly (556.57s)
--- PASS: TestAccPostgreSQLServer_gpTenPointZero (386.15s)
--- PASS: TestAccPostgreSQLServer_moTenPointZero (387.97s)
--- PASS: TestAccPostgreSQLServer_basicTenPointZero (441.76s)
--- PASS: TestAccPostgreSQLServer_basicWithIdentity (509.79s)
--- PASS: TestAccPostgreSQLServer_updated (1088.72s)
--- PASS: TestAccPostgreSQLServer_updateSKU (1151.99s)
--- PASS: TestAccPostgreSQLServer_basicNinePointSix (439.34s)
--- PASS: TestAccPostgreSQLServer_createReplica
--- PASS: TestAccPostgreSQLServer_updateReplicaToDefaultAndSetPassword
--- PASS: TestAccPostgreSQLServer_updateReplicaToDefault
--- PASS: TestAccPostgreSQLServer_scaleReplicas
--- PASS: TestAccPostgreSQLServer_createPointInTimeRestore

Copy link
Collaborator

@WodansSon WodansSon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@neil-yechenwei Thanks for the PR neil... LGTM! 🚀

@WodansSon WodansSon requested a review from katbyte April 29, 2022 01:03
@WodansSon WodansSon added this to the v3.4.0 milestone Apr 29, 2022
Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🦀

@WodansSon
Copy link
Collaborator

image

@WodansSon WodansSon merged commit b0cf3ae into hashicorp:main Apr 29, 2022
WodansSon added a commit that referenced this pull request Apr 29, 2022
@github-actions
Copy link

This functionality has been released in v3.4.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 30, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants