Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test Fixes - Swapping regions based on quota #16514

Merged
merged 4 commits into from
Apr 25, 2022
Merged

Test Fixes - Swapping regions based on quota #16514

merged 4 commits into from
Apr 25, 2022

Conversation

mbfrahry
Copy link
Member

Also fixes an issue brought up around #15749

@mbfrahry mbfrahry requested a review from a team April 22, 2022 21:36
@mbfrahry mbfrahry mentioned this pull request Apr 22, 2022
Merged
stephybun
stephybun reviewed Apr 25, 2022
View reviewed changes
internal/services/datafactory/data_factory_dataset_binary_resource.go
@@ -134,6 +134,11 @@ func resourceDataFactoryDatasetBinary() *pluginsdk.Resource {
Required: true,
ValidateFunc: validation.StringIsNotEmpty,
},
"dynamic_container_enabled": {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do these new properties need to be added to the tests and docs?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ohh, thanks for that catch!

@mbfrahry mbfrahry merged commit 23b5c87 into main Apr 25, 2022
@mbfrahry mbfrahry deleted the tf-threepointoh-14 branch April 25, 2022 18:44
@github-actions github-actions bot added this to the v3.4.0 milestone Apr 25, 2022
mbfrahry added a commit that referenced this pull request Apr 25, 2022
@mbfrahry
Update changelog for #16514
c066392
This was referenced Apr 25, 2022
Closed
Closed
@gregops312
Copy link
Contributor

@mbfrahry I would argue this PR also closes #16525

@github-actions
Copy link

This functionality has been released in v3.4.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 30, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@stephybun stephybun stephybun left review comments

Assignees
No one assigned
Labels
documentation service/data-factory size/XL
Projects
None yet
Milestone
v3.4.0
Development

Successfully merging this pull request may close these issues.
3 participants
@mbfrahry @gregops312 @stephybun