Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sentinel - removing setting etag before updating it #16428

Merged
merged 1 commit into from
Apr 20, 2022

Conversation

magodo
Copy link
Collaborator

@magodo magodo commented Apr 18, 2022

Previously, sentinel API requires an etag is set in the update request (PUT), which is trakced in Azure/azure-rest-api-specs#13203. While it appears this is not a must now, which aligns with ARM's expectation that etag should be optional.

Previously, sentinel API requires an `etag` is set in the update request (`PUT`), which is trakced in Azure/azure-rest-api-specs#13203. While it appears this is not a must now, which aligns with ARM's expectation that `etag` should be optional.
Copy link
Contributor

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@tombuildsstuff tombuildsstuff added this to the v3.3.0 milestone Apr 20, 2022
@tombuildsstuff tombuildsstuff merged commit f4d22f5 into hashicorp:main Apr 20, 2022
tombuildsstuff added a commit that referenced this pull request Apr 20, 2022
@github-actions
Copy link

This functionality has been released in v3.3.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 22, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants