Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

azurerm_stream_analytics_output_mssql - add support for new properties max_batch_count and max_writer_count #16409

Merged
merged 4 commits into from
Apr 20, 2022
Merged

azurerm_stream_analytics_output_mssql - add support for new properties max_batch_count and max_writer_count #16409

merged 4 commits into from
Apr 20, 2022

Conversation

neil-yechenwei
Copy link
Contributor

This PR is to support new properties max_batch_count and max_writer_count for azurerm_stream_analytics_output_mssql.

--- PASS: TestAccStreamAnalyticsOutputSql_basic (443.50s)
--- PASS: TestAccStreamAnalyticsOutputSql_requiresImport (452.65s)
--- PASS: TestAccStreamAnalyticsOutputSql_update (501.14s)
--- PASS: TestAccStreamAnalyticsOutputSql_maxBatchCountAndMaxWriterCount (812.85s)

stephybun
stephybun requested changes Apr 19, 2022
View reviewed changes
Copy link
Member

@stephybun stephybun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this PR @neil-yechenwei, one comment on the docs otherwise this should be good to go.

website/docs/r/stream_analytics_output_mssql.html.markdown Outdated Show resolved Hide resolved
@neil-yechenwei
Copy link
Contributor Author

@stephybun , thanks for your comment. I've updated code. Please take another look. Thanks.

stephybun
stephybun approved these changes Apr 20, 2022
View reviewed changes
Copy link
Member

@stephybun stephybun left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🌻 thanks @neil-yechenwei

@stephybun stephybun merged commit 5ef9d7b into hashicorp:main Apr 20, 2022
@github-actions github-actions bot added this to the v3.3.0 milestone Apr 20, 2022
stephybun added a commit that referenced this pull request Apr 20, 2022
@stephybun
Update for #16409
528a142
@github-actions
Copy link

This functionality has been released in v3.3.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 22, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@stephybun stephybun stephybun approved these changes

Assignees
No one assigned
Labels
documentation enhancement service/stream-analytics size/M
Projects
None yet
Milestone
v3.3.0
Development

Successfully merging this pull request may close these issues.
2 participants
@neil-yechenwei @stephybun