Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

azurerm_cosmosdb_sql_container,azurerm_cosmosdb_gremlin_graph: fix the case-insensitive issue about indexing_mode property after 3.0 release #16152

Merged
merged 2 commits into from
Apr 4, 2022
Merged

azurerm_cosmosdb_sql_container,azurerm_cosmosdb_gremlin_graph: fix the case-insensitive issue about indexing_mode property after 3.0 release #16152

merged 2 commits into from
Apr 4, 2022

Conversation

sinbai
Copy link
Contributor

@sinbai sinbai commented Mar 30, 2022

Fix issue #16086. The indexing_mode property should be case-sensitive in 3.0 model. Also, fix the same issue about azurerm_cosmosdb_gremlin_graph resource.

stephybun
stephybun requested changes Apr 1, 2022
View reviewed changes
Copy link
Member

@stephybun stephybun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this fix @sinbai, two minor comments but once those are resolved this should be good to go.

internal/services/cosmos/common/schema.go Outdated
@@ -121,7 +121,7 @@ func CosmosDbIndexingPolicySchema() *pluginsdk.Schema {
}

}
return validation.StringInSlice(keys, features.ThreePointOhBeta())
return validation.StringInSlice(keys, !features.ThreePointOhBeta())
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can start removing the ThreePointOh and ThreePointOhBeta flags

Suggested change
return validation.StringInSlice(keys, !features.ThreePointOhBeta())
return validation.StringInSlice(keys, false)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you. Fixed.

internal/services/cosmos/cosmosdb_gremlin_graph_resource.go Outdated
@@ -131,7 +131,7 @@ func resourceCosmosDbGremlinGraph() *pluginsdk.Resource {
"None",
}
}
return validation.StringInSlice(keys, features.ThreePointOhBeta())
return validation.StringInSlice(keys, !features.ThreePointOhBeta())
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
return validation.StringInSlice(keys, !features.ThreePointOhBeta())
return validation.StringInSlice(keys, false)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you. Fixed.

@stephybun stephybun added the bug label Apr 1, 2022
stephybun
stephybun approved these changes Apr 4, 2022
View reviewed changes
Copy link
Member

@stephybun stephybun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @sinbai, LGTM 🌻

@stephybun stephybun merged commit 70315c7 into hashicorp:main Apr 4, 2022
@github-actions github-actions bot added this to the v3.1.0 milestone Apr 4, 2022
stephybun added a commit that referenced this pull request Apr 4, 2022
@stephybun
Update for #16152
769e954
@sinbai sinbai deleted the cosmos/fix_issue_16086 branch April 6, 2022 02:13
catriona-m pushed a commit that referenced this pull request Apr 6, 2022
@sinbai @catriona-m
azurerm_cosmosdb_sql_container,azurerm_cosmosdb_gremlin_graph: fix th…
4ed8dca 
…e case-insensitive issue about indexing_mode property after 3.0 release (#16152)

* fix issue 16086

* update code
catriona-m pushed a commit that referenced this pull request Apr 6, 2022
@stephybun @catriona-m
Update for #16152
551763a
@github-actions
Copy link

github-actions bot commented Apr 8, 2022

This functionality has been released in v3.1.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

vdmgolub added a commit to infracost/infracost that referenced this pull request Apr 11, 2022
@vdmgolub
chore(azure): Fix tests for CosmosDB related resource
5f48d10 
The attribute is case-sensitive now. Fixed after provider's v3 release here:
hashicorp/terraform-provider-azurerm#16152.
@vdmgolub vdmgolub mentioned this pull request Apr 11, 2022
Merged
vdmgolub added a commit to infracost/infracost that referenced this pull request Apr 11, 2022
@vdmgolub
chore(azure): Fix tests for CosmosDB related resource
827d80d 
The attribute is case-sensitive now. Fixed after provider's v3 release here:
hashicorp/terraform-provider-azurerm#16152.
@github-actions
Copy link

github-actions bot commented May 9, 2022

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 9, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@stephybun stephybun stephybun approved these changes

Assignees
No one assigned
Labels
bug service/cosmosdb size/XS
Projects
None yet
Milestone
v3.1.0
Development

Successfully merging this pull request may close these issues.
2 participants
@sinbai @stephybun