Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azurerm_web_application_firewall_policy Fix #16019 by adding KNOWN-CVES to `ValidateWebApplicationFirewallP… #16080

Merged
merged 1 commit into from
Mar 31, 2022

Conversation

lonegunmanb
Copy link
Contributor

According to the document, we can set KNOWN-CVES as the rule_group_name. This pr will fix #16019 .

The acc tests failed not only on this branch but also on main branch, I guess I need to set some environment variables to make acc tests pass?

Copy link
Member

@jackofallops jackofallops left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @lonegunmanb - LGTM 👍

@jackofallops jackofallops added this to the v3.1.0 milestone Mar 31, 2022
@jackofallops jackofallops merged commit 0bea53b into hashicorp:main Mar 31, 2022
jackofallops added a commit that referenced this pull request Mar 31, 2022
@github-actions
Copy link

github-actions bot commented Apr 8, 2022

This functionality has been released in v3.1.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

github-actions bot commented May 9, 2022

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 9, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

WAF Managed Rule "Known-CVEs" cannot be disabled as it's not an expected value in rule_group_name
2 participants