Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Data Source azurerm_managed_api & New Resource: azurerm_api_connection #15797

Merged
merged 6 commits into from
Mar 14, 2022

Conversation

tombuildsstuff
Copy link
Contributor

This PR introduces support for creating API Connections, which also required creating a Data Source to retrieve the Managed API information.

Whilst this creates the API Connection resource this doesn't handle linking these to other resources (such as Logic Apps) - which'll need to be tracked in a separate issue, but allowing the creation of these is a step forward at any rate.

Unfortunately the API Version used in the Azure Portal doesn't have associated Swagger in the Azure Rest API Specs repository, as such I've had to use an older API version which doesn't allow the update of Parameters - which (whilst obviously not ideal) seemed like a worthwhile trade-off here.

Fixes #1691

Copy link
Contributor

@manicminer manicminer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One question about the docs for azurerm_api_connection but otherwise LGTM 👍

website/docs/r/api_connection.html.markdown Outdated Show resolved Hide resolved
@tombuildsstuff
Copy link
Contributor Author

Tests pass:

Screenshot 2022-03-14 at 15 16 35

@tombuildsstuff tombuildsstuff merged commit fc795d9 into main Mar 14, 2022
@tombuildsstuff tombuildsstuff deleted the f/connections branch March 14, 2022 14:18
tombuildsstuff added a commit that referenced this pull request Mar 14, 2022
@github-actions
Copy link

This functionality has been released in v3.0.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 24, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Logic Apps: support for connections
2 participants