Allow - in disk snapshot names

[CoRfr]

It appears that - was omitted from the possible character in snapshot
names.

It doesn't seem like there is any issue when using - in the name, as
I was able to create snapshots with dashes both from the portal and
through this plugin (with this patch applied).

[CoRfr]

Oh I see where the format is coming from:

https://docs.microsoft.com/en-us/rest/api/compute/snapshots/update

The name of the snapshot that is being created. The name can't be changed after the snapshot is created. Supported characters for the name are a-z, A-Z, 0-9 and _. The max name length is 80 characters.

In practice though, it appears that '-' is supported. I'm not sure how to request REST API updates.

[CoRfr]

Also it seems that disks have the same requirements for names, which is not enforced in terraform:
https://docs.microsoft.com/en-us/rest/api/compute/disks/createorupdate

The documentation is also outdated since - are clearly accepted for disk names as well.

[tombuildsstuff]

LGTM - thanks for this 👍

[tombuildsstuff]

hi @CoRfr

Just to let you know that is now available in [v1.10 of the AzureRM Provider(https://github.com/terraform-providers/terraform-provider-azurerm/blob/v1.10.0/CHANGELOG.md#1100-july-21-2018) - which you can update to this version by specifying it in the Provider block, like so:

provider "azurerm" {
  version = "=1.10.0"
}

Thanks!

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!