New resource: azurerm_virtual_network_gateway_nat_rule

[neil-yechenwei]

To resolve the issue #15348, it has to implement Virtual Network Gateway Nat Rule first. Once this PR is merged, I assume it has to submit another PR to implement egressNatRules and ingressNatRules of Virtual Network Gateway Connection (azurerm_virtual_network_gateway_connection).

--- PASS: TestAccVirtualNetworkGatewayNatRule_basic (2589.57s)
--- PASS: TestAccVirtualNetworkGatewayNatRule_updatePortRange (2697.90s)
--- PASS: TestAccVirtualNetworkGatewayNatRule_complete (2774.72s)
--- PASS: TestAccVirtualNetworkGatewayNatRule_requiresImport (2803.29s)
--- PASS: TestAccVirtualNetworkGatewayNatRule_update (3078.08s)

API reference:
https://github.com/Azure/azure-rest-api-specs/blob/main/specification/network/resource-manager/Microsoft.Network/stable/2021-05-01/virtualNetworkGateway.json#L2389

[katbyte]

@neil-yechenwei based on #15348 it appears that we also need to split the Create and Update method for Virtual Network Gateway such that that update does a Delta update for this to work - would you be able to take a look?

Thanks!

[neil-yechenwei]

@katbyte , seems the Potential Terraform Configuration in #15348 has some problem. Per my understanding and testing, I assume we should implement Virtual Network Gateway Nat Rule resource first and then implement the egressNatRules and ingressNatRules of Virtual Network Gateway Connection (azurerm_virtual_network_gateway_connection) for the association. In addition, azurerm_virtual_network_gateway_connection is using separate API client Network.VnetGatewayConnectionsClient and azurerm_virtual_network_gateway_nat_rule is also using separate API client Network.VnetGatewayNatRuleClient. So I assume we don't need to split the create and update method for the Virtual Network Gateway (azurerm_virtual_network_gateway). Does it make sense?

[katbyte]

Why would the fact the use a different client make a difference? they both alter the same resource and if someone wants to be able to go lifecycle ignore changes the create and update needs to be seperate. So can we please split the create and update?

[neil-yechenwei]

@katbyte , I referred the existing resources nsg and nsr. So I used the separate api client here.

I splitted the create and update.

[katbyte]

Thanks @neil-yechenwei - LGTM 🦋

[github-actions]

This functionality has been released in v3.7.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.