Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[New Resource] azurerm_confidential_ledger - Add Azure Confidential Ledger Terraform Resource #15420

Merged
merged 44 commits into from
May 12, 2022
Merged

Conversation

lynshi
Copy link
Contributor

@lynshi lynshi commented Feb 15, 2022

This adds Terraform definitions for Azure Confidential Ledger based on our Public Preview API. We use the Hashicorp SDK generated from our REST API spec (as opposed to the Azure Go SDK).

@WodansSon WodansSon changed the title Add Azure Confidential Ledger Terraform Resource [New Resource] azurerm_confidential_ledger - Add Azure Confidential Ledger Terraform Resource Feb 15, 2022
@WodansSon WodansSon added this to the v2.97.0 milestone Feb 15, 2022
@katbyte katbyte modified the milestones: v2.97.0, v2.98.0 Feb 18, 2022
@tombuildsstuff tombuildsstuff modified the milestones: v2.98.0, v2.99.0 Feb 25, 2022
@hashicorp hashicorp deleted a comment from github-actions bot Mar 2, 2022
@tombuildsstuff tombuildsstuff self-assigned this Mar 2, 2022
@tombuildsstuff
Copy link
Contributor

hi @lynshi

Thanks for this PR.

Since this is using an Embedded SDK I've pulled this down locally to check it matches what we're expecting and it appears there's a number of changes present - as such I hope you don't mind but I've ended up pushing a commit to update the Embedded SDK.

As I've pulled this down locally to update that, I ended up passing through the data sources/resources locally anyway - as such I hope you don't mind but I've pushed a couple of commits to this PR to update this so that we can get this merged.

Thanks!

@tombuildsstuff tombuildsstuff requested a review from a team March 3, 2022 12:24
@tombuildsstuff tombuildsstuff removed their assignment Mar 3, 2022
@lynshi
Copy link
Contributor Author

lynshi commented Mar 3, 2022

Hi @tombuildsstuff - appreciate the help and thank you! No worries at all. I had changed the auto-generated SDK slightly though I don't remember why.

I pulled the changes and ran it. Mostly looks good but I think one of the updates is disallowed (changes a property that can't be modified after creation), so the certBased test didn't pass. I'll push a fix likely tomorrow.

@lynshi
Copy link
Contributor Author

lynshi commented Mar 4, 2022

Sorry for the delay - I've verified that our resource tests pass and pushed the changes.

@tombuildsstuff tombuildsstuff modified the milestones: v2.99.0, v3.0.0 Mar 11, 2022
@tombuildsstuff tombuildsstuff modified the milestones: v3.0.0, v3.1.0 Mar 23, 2022
@katbyte katbyte modified the milestones: v3.1.0, v3.2.0 Apr 7, 2022
@koikonom
Copy link
Contributor

koikonom commented Apr 8, 2022

Rebased to resolve conflicts.

@katbyte katbyte modified the milestones: v3.2.0, v3.3.0 Apr 14, 2022
@katbyte katbyte modified the milestones: v3.3.0, v3.4.0 Apr 22, 2022
@hashicorp hashicorp deleted a comment from github-actions bot Apr 22, 2022
@katbyte katbyte modified the milestones: v3.4.0, v3.5.0, v3.6.0 Apr 29, 2022
@lynshi
Copy link
Contributor Author

lynshi commented May 9, 2022

Hi, can I please get an update on this? The PR's been open for almost 3 months and I keep seeing milestones get added/removed, so just wanted to make sure we're on track as this is a requirement for General Availability of Azure Confidential Ledger.

@koikonom koikonom merged commit 1304911 into hashicorp:main May 12, 2022
koikonom pushed a commit that referenced this pull request May 12, 2022
@lynshi lynshi deleted the lyshi/acl-terraform branch May 12, 2022 17:27
@github-actions
Copy link

This functionality has been released in v3.6.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 17, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants