Fix azure table storage name length requirement.

[mjgpy3]

https://docs.microsoft.com/en-us/rest/api/storageservices/Understanding-the-Table-Service-Data-Model?redirectedfrom=MSDN#table-names.

I'm not sure if this requirement changed since this was created, but it's currently breaking my infrastructure because I have a 5-character-name table.

I'm having difficulty getting my go dev environment set up so this will likely break tests. I'll fix them once the red build comes back.

[mjgpy3]

Ope, guess the build didn't break. Let me know your thoughts!

[tombuildsstuff]

Hey @mjgpy3

Thanks for opening this PR - this validation change LGTM :)

Whilst the tests currently pass - would you mind adding some additional test cases to the Acceptance Test to better match the validation rules?

Thanks!

[mjgpy3]

Absolutely, I'll add some test as soon as I get the chance.

[mjgpy3]

@tombuildsstuff tests added.

[tombuildsstuff]

Hey @mjgpy3

Thanks for pushing the latest changes. I've taken a look and this LGTM - tests pass:

$ TF_ACC=1 envchain azurerm go test ./azurerm -v -timeout 120m -run TestValidateArmStorageTableName
=== RUN   TestValidateArmStorageTableName
--- PASS: TestValidateArmStorageTableName (0.00s)
PASS
ok  	github.com/terraform-providers/terraform-provider-azurerm/azurerm	0.023s

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!