Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azurerm_automation_schedule_resource: Changing Automation Time Helper to be 'Etc/UTC' rather than just 'UTC' #13906

Merged
merged 3 commits into from
Oct 27, 2021

Conversation

SudoSpartanDan
Copy link
Contributor

Fixes #13666

Per Microsoft Support:

Support:

Per one SME this is expected behavior and the “norm” now. Just to verify I went to another SME to see if they told me the same thing. I am currently waiting to hear back from them. I have resurfaced the conversation I had with them so I expect to hear back from them today. It would seem this is expected behavior at this point though.

Me:

Thanks for digging in. So, just to verify, we should expect the timezone to be “Etc/UTC” rather than “UTC”? Is this just for the automation API or for all APIs?

Support:

That I cannot answer because I don’t have insights into other teams API’s. For Monitoring and Automation, as of right now yes.

make acctests SERVICE='automation' TESTARGS='-run=TestAccAutomationSchedule_oneTime_basic' TESTTIMEOUT='60m'
==> Checking that code complies with gofmt requirements...
==> Checking that Custom Timeouts are used...
==> Checking that acceptance test packages are used...
TF_ACC=1 go test -v ./internal/services/automation -run=TestAccAutomationSchedule_oneTime_basic -timeout 60m -ldflags="-X=github.com/hashicorp/terraform-provider-azurerm/version.ProviderVersion=acc"
=== RUN   TestAccAutomationSchedule_oneTime_basic
=== PAUSE TestAccAutomationSchedule_oneTime_basic
=== CONT  TestAccAutomationSchedule_oneTime_basic
--- PASS: TestAccAutomationSchedule_oneTime_basic (99.90s)
PASS
ok      github.com/hashicorp/terraform-provider-azurerm/internal/services/automation    99.949s

@SudoSpartanDan SudoSpartanDan changed the title Changing Automation Time Helper to be 'Etc/UTC' rather than just 'UTC' automattion: Changing Automation Time Helper to be 'Etc/UTC' rather than just 'UTC' Oct 26, 2021
@SudoSpartanDan SudoSpartanDan changed the title automattion: Changing Automation Time Helper to be 'Etc/UTC' rather than just 'UTC' automation: Changing Automation Time Helper to be 'Etc/UTC' rather than just 'UTC' Oct 26, 2021
Copy link
Member

@jackofallops jackofallops left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @SudoSpartanDan - Thanks for this. I've left a couple comments inline about how we'd need to approach this change. Since Azure is accepting both values currently, and we need to avoid unexpected diffs for users that are relying on the current default value, we need to proceed in a staged manner. Additionally, not every service that uses timezone strings may have rolled out this change in all regions.

Thanks again.

helpers/validate/time.go Outdated Show resolved Hide resolved
@SudoSpartanDan
Copy link
Contributor Author

Thanks @jackofallops good point on those. Initially, I saw that only the automation tools were using the time helper, so that's why I made the abrupt change. It's a good point, though, that others could use this as well.

@katbyte katbyte added this to the v2.83.0 milestone Oct 27, 2021
@katbyte katbyte changed the title automation: Changing Automation Time Helper to be 'Etc/UTC' rather than just 'UTC' azurerm_automation_schedule_resource: Changing Automation Time Helper to be 'Etc/UTC' rather than just 'UTC' Oct 27, 2021
Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @SudoSpartanDan - LGTM ⛏️

@katbyte katbyte merged commit aa4c449 into hashicorp:main Oct 27, 2021
katbyte added a commit that referenced this pull request Oct 27, 2021
@github-actions
Copy link

This functionality has been released in v2.83.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 28, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

azurerm_automation_schedule timezone default does not match azure values
3 participants