-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
azurerm_automation_schedule_resource: Changing Automation Time Helper to be 'Etc/UTC' rather than just 'UTC' #13906
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @SudoSpartanDan - Thanks for this. I've left a couple comments inline about how we'd need to approach this change. Since Azure is accepting both values currently, and we need to avoid unexpected diffs for users that are relying on the current default value, we need to proceed in a staged manner. Additionally, not every service that uses timezone strings may have rolled out this change in all regions.
Thanks again.
Co-authored-by: jackofallops <[email protected]>
Thanks @jackofallops good point on those. Initially, I saw that only the automation tools were using the time helper, so that's why I made the abrupt change. It's a good point, though, that others could use this as well. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @SudoSpartanDan - LGTM ⛏️
This functionality has been released in v2.83.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions. |
Fixes #13666
Per Microsoft Support:
Support:
Me:
Support: