-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
r\managed_disk
: Add support for trusted_launch_enabled
#13849
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hey @myc2h6o
Thanks for this PR.
I've taken a look through and left a few comments inline - if we can fix those up then we should be good to go 👍
Thanks!
@tombuildsstuff thanks for reviewing the change! I've update the pr according to your suggestions. Please take another look. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @myc2h6o - LGTM 🙌
r\managed_disk
: Add support for security_type
r\managed_disk
: Add support for trusted_launch_enabled
This functionality has been released in v2.83.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions. |
TrustedLaunch
, and requirescreate_option
to beFromImage
orImport
UbuntuServer 18_04-LTS-gen2
is used as the image$ TF_ACC=1 go test -v ./internal/services/compute -run=TestAccAzureRMManagedDisk_create_withTrustedLaunchEnabled -timeout 60m -ldflags="-X=github.com/hashicorp/terraform-provider-azurerm/version.ProviderVersion=acc"
=== RUN TestAccAzureRMManagedDisk_create_withTrustedLaunchEnabled
=== PAUSE TestAccAzureRMManagedDisk_create_withTrustedLaunchEnabled
=== CONT TestAccAzureRMManagedDisk_create_withTrustedLaunchEnabled
--- PASS: TestAccAzureRMManagedDisk_create_withTrustedLaunchEnabled (333.34s)
PASS
ok github.com/hashicorp/terraform-provider-azurerm/internal/services/compute 334.051s