Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New resource azurerm_stream_analytics_reference_input_mssql #13822

Merged
merged 9 commits into from
Oct 22, 2021

Conversation

stephybun
Copy link
Member

@stephybun stephybun commented Oct 21, 2021

Fixes #9231

Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @stephybun - aside from a couple comments LGTM 🏗️

}, false),
},

"refresh_rate": {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we include the units here?

Suggested change
"refresh_rate": {
"refresh_rate_in_seconds": {
Suggested change
"refresh_rate": {
"refresh_rate_in_hours": {

looks like this is actually a duration?

Suggested change
"refresh_rate": {
"refresh_interval_duration": {

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense!

* `password` - (Required) The username to connect to the MS SQL database.

* `refresh_type` - (Required) Defines whether and how the reference data should be refreshed. Accepted values are `Static`, `RefreshPeriodicallyWithFull` and `RefreshPeriodicallyWithDelta`.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i don't see refresh duration?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was down the bottom, but it should probably be grouped with refresh_type

@stephybun stephybun merged commit e98bc93 into main Oct 22, 2021
@stephybun stephybun deleted the f/stream-analytics-mssql-reference-input branch October 22, 2021 08:14
@stephybun stephybun added this to the v2.83.0 milestone Nov 19, 2021
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 20, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for Azure Stream Analytics Reference Input MSSQL
2 participants