Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Networking Updates #138

Merged
merged 6 commits into from
Jun 27, 2017
Merged

Networking Updates #138

merged 6 commits into from
Jun 27, 2017

Conversation

tombuildsstuff
Copy link
Contributor

@tombuildsstuff tombuildsstuff commented Jun 27, 2017

Made network_security_group_name a ForceNew in Network Security Rule's

Otherwise documentation updates:

  • Adding disclaimers to match the AWS resources:
    • Virtual Networks/Subnets - about inline/separate resources conflicting
    • Network Security Groups / Network Security Rules - about inline/separate resources conflicting
    • ARM Template Deployments about what an ARM Template Deployment actually is
  • Re-organising the Network sidebar to be alphabetical like the other groupings
  • Fixing the highlighting for Express Route's / Local Network Gateway's

Fixes #115 #65

@tombuildsstuff
Copy link
Contributor Author

Network Security Rule tests:

$ TF_ACC=1 envchain azurerm go test ./azurerm -v -timeout 300m -parallel 5 -run TestAccAzureRMNetworkSecurityRule
=== RUN   TestAccAzureRMNetworkSecurityRule_importBasic
--- PASS: TestAccAzureRMNetworkSecurityRule_importBasic (100.68s)
=== RUN   TestAccAzureRMNetworkSecurityRule_basic
--- PASS: TestAccAzureRMNetworkSecurityRule_basic (114.90s)
=== RUN   TestAccAzureRMNetworkSecurityRule_disappears
--- PASS: TestAccAzureRMNetworkSecurityRule_disappears (117.64s)
=== RUN   TestAccAzureRMNetworkSecurityRule_addingRules
--- PASS: TestAccAzureRMNetworkSecurityRule_addingRules (132.55s)
PASS
ok  	github.com/terraform-providers/terraform-provider-azurerm/azurerm	465.834s

Copy link
Member

@mbfrahry mbfrahry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@tombuildsstuff tombuildsstuff merged commit 964e791 into master Jun 27, 2017
@tombuildsstuff tombuildsstuff deleted the documentation branch June 27, 2017 16:17
tombuildsstuff added a commit that referenced this pull request Jun 27, 2017
tombuildsstuff added a commit that referenced this pull request Jul 4, 2017
tombuildsstuff added a commit that referenced this pull request Jul 4, 2017
@ghost
Copy link

ghost commented Apr 1, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 1, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

network_security_rule - unnecessary removal
2 participants