Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azurerm_batch_account - add supports for identity #13742

Merged
merged 4 commits into from
Oct 21, 2021

Conversation

magodo
Copy link
Collaborator

@magodo magodo commented Oct 15, 2021

Fixes #8532

Test Result

💢 TF_ACC=1 go test -timeout=3h -v ./internal/services/batch -run='TestAccBatchAccount_identity'
=== RUN   TestAccBatchAccount_identity
=== PAUSE TestAccBatchAccount_identity
=== CONT  TestAccBatchAccount_identity
--- PASS: TestAccBatchAccount_identity (276.74s)
PASS
ok      github.com/hashicorp/terraform-provider-azurerm/internal/services/batch 276.890s


* `type` - The identity type of the Batch Account. Possible values are `SystemAssigned` and `UserAssigned`.

* `identity_ids` - (Optional) Specifies a list of user assigned identity ids. Required if `type` is `UserAssigned`.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Last one: probably also required on type = "SystemAssigned, UserAssigned"?

Suggested change
* `identity_ids` - (Optional) Specifies a list of user assigned identity ids. Required if `type` is `UserAssigned`.
* `identity_ids` - (Optional) Specifies a list of user assigned identity ids. Required if `type` is `UserAssigned` or `SystemAssigned, UserAssigned`.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@aristosvo In fact the batch account doesn't support the SystemAssigned, UserAssigned type. That's why I didn't mention that in the document of the type property.

Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @magodo - LGTM 🚀

@katbyte katbyte merged commit 670f9a3 into hashicorp:main Oct 21, 2021
katbyte added a commit that referenced this pull request Oct 21, 2021
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 20, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
3 participants