-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
r/azurerm_security_center_workspace
: Allow creation with Free
pricing tier
#13710
r/azurerm_security_center_workspace
: Allow creation with Free
pricing tier
#13710
Conversation
b91b4a6
to
06f966b
Compare
r/azurerm_security_center_workspace
: Allow creation with Free
pricing tier
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@favoretti Thanks for this update. The tier change is working for me although I'm seeing a post-apply diff. I'm also wondering if the combined test can now be gotten rid of since the pricing restriction doesn't apply any more?
=== CONT TestAccSecurityCenter_pricingAndWorkspace/workspace/basic
testcase.go:88: Step 1/3 error: After applying this test step, the plan was not empty.
stdout:
Terraform used the selected providers to generate the following execution
plan. Resource actions are indicated with the following symbols:
~ update in-place
Terraform will perform the following actions:
# azurerm_security_center_workspace.test will be updated in-place
~ resource "azurerm_security_center_workspace" "test" {
id = "/subscriptions/1a6092a6-137e-4025-9a7c-ef77f76f2c02/providers/Microsoft.Security/workspaceSettings/default"
~ workspace_id = "/subscriptions/1a6092a6-137e-4025-9a7c-ef77f76f2c02/resourceGroups/acctestrg-sc-211012234838472760/providers/Microsoft.OperationalInsights/workspaces/acctest-211012234838472760-1" -> "/subscriptions/1a6092a6-137e-4025-9a7c-ef77f76f2c02/resourceGroups/acctestRG-sc-211012234838472760/providers/Microsoft.OperationalInsights/workspaces/acctest-211012234838472760-1"
# (1 unchanged attribute hidden)
}
Plan: 0 to add, 1 to change, 0 to destroy.
--- FAIL: TestAccSecurityCenter_pricingAndWorkspace/workspace/basic (121.55s)
FAIL
@manicminer christ. Resourcegroup casing again.. 🤦🏻♂️ I'll split the tests again and see whether I can fix up acceptance tests. Thanks for your review! |
…s RG name all lowercased.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
This functionality has been released in v2.81.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions. |
azurerm_security_center_workspace
is now allowed with pricing tier set toFree
, so the limitation in the code is removed too.