VMSS - add feature for scale_in_on_delete #13635
Conversation
There was a problem hiding this comment.
hey @hbuckle
Thanks for this PR - taking a look through this mostly LGTM, however I think we want to rename this to scale_to_zero_before_deletion so it's clearer exactly what this does - WDYT?
Thanks!
internal/features/defaults.go
Outdated
| @@ -33,6 +33,7 @@ func Default() UserFeatures { | |||
| VirtualMachineScaleSet: VirtualMachineScaleSetFeatures{ | |||
| ForceDelete: false, | |||
| RollInstancesWhenRequired: true, | |||
| ScaleInOnDelete: true, | |||
There was a problem hiding this comment.
I think it'd be worth calling this ScaleToZeroOnDelete rather than ScaleIn so it's a little more explicit?
internal/provider/features_test.go
Outdated
| "virtual_machine_scale_set": []interface{}{ | ||
| map[string]interface{}{ | ||
| "force_delete": false, | ||
| "scale_in_on_delete": false, |
There was a problem hiding this comment.
doesn't this also require RollInstancesWhenRequired set?
| @@ -136,6 +136,10 @@ func schemaFeatures(supportLegacyTestSuite bool) *pluginsdk.Schema { | |||
| Type: pluginsdk.TypeBool, | |||
| Required: true, | |||
There was a problem hiding this comment.
outside of the scope of this PR, but I'm surprised that this is required - this should be Optional
There was a problem hiding this comment.
Something else I noticed is that force_delete doesn't appear to actually be implemented
|
This functionality has been released in v2.83.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions. |
Not done anything to do with features before, hopefully this is ok.
Fixes #13569