azurerm_lb, azurerm_lb_backend_address_pool, azurerm_network_interface - add supports for gateway LB
#13559
Conversation
magodo
added
enhancement
service/load-balancers
and removed
documentation
size/XL
labels
There was a problem hiding this comment.
Could we add the instrudctions to the docs that are required to enable the required features?
------- Stdout: -------
=== RUN TestAccBackendAddressPoolGatewaySkuUpdate
=== PAUSE TestAccBackendAddressPoolGatewaySkuUpdate
=== CONT TestAccBackendAddressPoolGatewaySkuUpdate
testcase.go:88: Step 1/6 error: Error running apply: exit status 1
Error: creating/updating Load Balancer "acctestlb-210930175846005171" (Resource Group "acctestRG-210930175846005171"): network.LoadBalancersClient#CreateOrUpdate: Failure sending request: StatusCode=0 -- Original Error: Code="SubscriptionNotRegisteredForFeature" Message="Subscription ******* is not registered for feature Microsoft.Network/AllowGatewayLoadBalancer required to carry out the requested operation." Details=[]
with azurerm_lb.test,
on terraform_plugin_test.tf line 27, in resource "azurerm_lb" "test":
27: resource "azurerm_lb" "test" {
--- FAIL: TestAccBackendAddressPoolGatewaySkuUpdate (194.51s)
FAIL
| @@ -103,6 +103,50 @@ func TestAccBackendAddressPoolStandardSkuRequiresImport(t *testing.T) { | |||
| }) | |||
| } | |||
|
|
|||
| func TestAccBackendAddressPoolGatewaySkuBasic(t *testing.T) { | |||
There was a problem hiding this comment.
we should have a _ in here
| func TestAccBackendAddressPoolGatewaySkuBasic(t *testing.T) { | |
| func TestAccBackendAddressPool_GatewaySkuBasic(t *testing.T) { |
There was a problem hiding this comment.
I'm doing this so to be consistent with other test case namings in this file. I'll do the change per above suggestion though.
| }) | ||
| } | ||
|
|
||
| func TestAccBackendAddressPoolGatewaySkuUpdate(t *testing.T) { |
There was a problem hiding this comment.
| func TestAccBackendAddressPoolGatewaySkuUpdate(t *testing.T) { | |
| func TestAccBackendAddressPool_GatewaySkuUpdate(t *testing.T) { |
There was a problem hiding this comment.
I'm doing this so to be consistent with other test case namings in this file. I'll do the change per above suggestion though.
|
@katbyte I've updated the PR per your comment. Meanwhile, I've asked the service team to register the feature for the two Hashicorp subscriptions. |
|
I've registered the subs last week as discussed |
|
@katbyte I've merged with the main branch, please take another look. |
|
This functionality has been released in v2.82.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions. |
This PR adds support for the Gateway Loadbalancer. Checkout the Swagger definition for examples.
There are two principals in the use case of the gateway LB: the provider and the consumer. The provider is the one that provisions the gateway loadbalancer, where the loadbalancer's sku is set to
Gatewayand its BAP has thetunnel_interfacedefined. The consumer is the one that directs its traffic to the provider gateway LB. There are currently two resources can consume (point to) the gateway LB: theazurerm_lband theazurerm_network_interface. For these two resources, this PR has added thegateway_load_balancer_frontend_ip_configuration_idto their forntend configuration block (arguably, the name of the property is a bit too verbose, while I didn't figure out another better name 😅 )Probably related to #13453
Test